Avoid loading the chrome sign-in URLs in incognito

Avoid loading the chrome sign-in URLs in incognito

Chrome sign-in URLS are only supposed to be open in regular profiles and
loading them in incognito or guest profiles leads to crashes.

This CL avoids loading these URLs on incognito profiles.

Screenshots after this change in a guest session:
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbeHUxR0lZbGs4OFU/view?usp=sharing
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbV2I4TnJ4enpuazg/view?usp=sharing
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbLWdVOUZkc0JfeEU/view?usp=sharing

BUG=679265
Review-Url: https://codereview.chromium.org/2621083002
Cr-Commit-Position: refs/heads/master@{#443014}
Committed: https://chromium.googlesource.com/chromium/src/+/a80bb6a60810ca919a1d01bc391716c040070b4f

[msarda, 2017-01-10 17:31:07]

msarda@chromium.org changed reviewers:
+ anthonyvd@chromium.org, xiyuan@chromium.org

[msarda, 2017-01-10 17:31:08]

Please take a look.

[anthonyvd, 2017-01-10 20:36:45]

What's the behavior after this change when navigating to one of the URLs in
incognito? Does it just show a blank page?

[msarda, 2017-01-10 22:31:38]

It shows an error page (page not found). I'll make a screenshot tomorrow.

[msarda, 2017-01-11 09:23:48]

Description was changed from

==========
Avoid loading the chrome sign-in URLs in incognito

Chrome sign-in URLS are only supposed to be open in regular profiles and
loading them in incognito or guest profiles leads to crashes.

This CL avoids loading these URLs on incognito profiles.

BUG=679265
==========

to

==========
Avoid loading the chrome sign-in URLs in incognito

Chrome sign-in URLS are only supposed to be open in regular profiles and
loading them in incognito or guest profiles leads to crashes.

This CL avoids loading these URLs on incognito profiles.

Screenshots after this change in a guest session:
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbeHUxR0lZbGs4OFU/v...
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbV2I4TnJ4enpuazg/v...
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbLWdVOUZkc0JfeEU/v...

BUG=679265
==========

[msarda, 2017-01-11 09:24:18]

I've added the screenshots in the CL description.

[xiyuan, 2017-01-11 17:51:48]

lgtm

[msarda, 2017-01-11 17:52:49]

The CQ bit was checked by msarda@chromium.org

[commit-bot: I haz the power, 2017-01-11 17:53:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 22:22:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484157169798060, "parent_rev":
"87f7645fd8cf2ce0c2a6964a5b9674b875063319", "commit_rev":
"a80bb6a60810ca919a1d01bc391716c040070b4f"}

[commit-bot: I haz the power, 2017-01-11 22:22:42]

Description was changed from

==========
Avoid loading the chrome sign-in URLs in incognito

Chrome sign-in URLS are only supposed to be open in regular profiles and
loading them in incognito or guest profiles leads to crashes.

This CL avoids loading these URLs on incognito profiles.

Screenshots after this change in a guest session:
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbeHUxR0lZbGs4OFU/v...
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbV2I4TnJ4enpuazg/v...
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbLWdVOUZkc0JfeEU/v...

BUG=679265
==========

to

==========
Avoid loading the chrome sign-in URLs in incognito

Chrome sign-in URLS are only supposed to be open in regular profiles and
loading them in incognito or guest profiles leads to crashes.

This CL avoids loading these URLs on incognito profiles.

Screenshots after this change in a guest session:
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbeHUxR0lZbGs4OFU/v...
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbV2I4TnJ4enpuazg/v...
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbLWdVOUZkc0JfeEU/v...

BUG=679265

Review-Url: https://codereview.chromium.org/2621083002
Cr-Commit-Position: refs/heads/master@{#443014}
Committed:
https://chromium.googlesource.com/chromium/src/+/a80bb6a60810ca919a1d01bc3917...
==========

[commit-bot: I haz the power, 2017-01-11 22:22:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a80bb6a60810ca919a1d01bc3917...