Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: gypfiles/features.gypi

Issue 2621033002: Revert of [build] Introduce an embedder version string (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | include/v8-version.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gypfiles/features.gypi
diff --git a/gypfiles/features.gypi b/gypfiles/features.gypi
index 4669fcf8bad8137d1425a2bb46f60d7243e657ef..f82a59f0f82f53718bae76fc53e248c89f541577 100644
--- a/gypfiles/features.gypi
+++ b/gypfiles/features.gypi
@@ -64,9 +64,6 @@
# Enable compiler warnings when using V8_DEPRECATE_SOON apis.
'v8_imminent_deprecation_warnings%': 0,
- # Allow the embedder to add a custom suffix to the version string.
- 'v8_embedder_string%': '',
-
# Set to 1 to enable DCHECKs in release builds.
'dcheck_always_on%': 0,
@@ -108,9 +105,6 @@
['v8_use_snapshot=="true" and v8_use_external_startup_data==1', {
'defines': ['V8_USE_EXTERNAL_STARTUP_DATA',],
}],
- ['v8_embedder_string!=""', {
- 'defines': ['V8_EMBEDDER_STRING="<(v8_embedder_string)"',],
- }],
['dcheck_always_on!=0', {
'defines': ['DEBUG',],
}],
« no previous file with comments | « BUILD.gn ('k') | include/v8-version.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698