Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: BUILD.gn

Issue 2621033002: Revert of [build] Introduce an embedder version string (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gypfiles/features.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index d6e5d94e83b9fe8cde8c4c1bb2dacd4108db40fb..2347be6be86af5af240b6f0f2d72ca3e4f03ff55 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -28,9 +28,6 @@
# Enable compiler warnings when using V8_DEPRECATED apis.
v8_deprecation_warnings = false
-
- # Allow the embedder to add a custom suffix to the version string.
- v8_embedder_string = ""
# Enable compiler warnings when using V8_DEPRECATE_SOON apis.
v8_imminent_deprecation_warnings = ""
@@ -176,10 +173,6 @@
visibility = [ ":*" ] # Only targets in this file can depend on this.
defines = []
-
- if (v8_embedder_string != "") {
- defines += [ "V8_EMBEDDER_STRING=\"$v8_embedder_string\"" ]
- }
if (v8_enable_disassembler) {
defines += [ "ENABLE_DISASSEMBLER" ]
« no previous file with comments | « no previous file | gypfiles/features.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698