third_party/WebKit/Source/core/loader/LinkLoader.h - Issue 2620993002: Fix HTMLPreloadScanner handling of type in link preload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/LinkLoader.h

Issue 2620993002: Fix HTMLPreloadScanner handling of type in link preload. (Closed)

Patch Set: Review comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/LinkLoader.h

diff --git a/third_party/WebKit/Source/core/loader/LinkLoader.h b/third_party/WebKit/Source/core/loader/LinkLoader.h

index f67b44638ca6ba45b7d7edf9fa5d1c59750e9a74..1572fda85757406422d2296b2e254cb2e1578d3c 100644

--- a/third_party/WebKit/Source/core/loader/LinkLoader.h

+++ b/third_party/WebKit/Source/core/loader/LinkLoader.h

@@ -41,6 +41,7 @@

#include "platform/PrerenderClient.h"

#include "platform/Timer.h"

#include "platform/heap/Handle.h"

+#include "wtf/Optional.h"

namespace blink {

@@ -101,7 +102,8 @@ class CORE_EXPORT LinkLoader final

CanLoadResources,

MediaPreloadPolicy,

ViewportDescriptionWrapper*);

- static bool getResourceTypeFromAsAttribute(const String& as, Resource::Type&);

+ static WTF::Optional<Resource::Type> getResourceTypeFromAsAttribute(

+ const String& as);

DECLARE_TRACE();