third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp - Issue 2620993002: Fix HTMLPreloadScanner handling of type in link preload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp

Issue 2620993002: Fix HTMLPreloadScanner handling of type in link preload. (Closed)

Patch Set: Review comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp ('k') | third_party/WebKit/Source/core/loader/LinkLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp b/third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp

index 37880414871fc20d225249e5ff9d04817b5ef41c..f5e3fe61270a8aefe9589a07fc9fbbc76d3877c9 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp

@@ -723,12 +723,33 @@ TEST_F(HTMLPreloadScannerTest, testLinkRelPreload) {

"http://example.test/", Resource::Raw, 0},

{"http://example.test", "<link rel=preload href=bla as=script>", "bla",

"http://example.test/", Resource::Script, 0},

+ {"http://example.test",

+ "<link rel=preload href=bla as=script type='script/foo'>", "bla",

+ "http://example.test/", Resource::Script, 0},

{"http://example.test", "<link rel=preload href=bla as=style>", "bla",

"http://example.test/", Resource::CSSStyleSheet, 0},

+ {"http://example.test",

+ "<link rel=preload href=bla as=style type='text/css'>", "bla",

+ "http://example.test/", Resource::CSSStyleSheet, 0},

+ {"http://example.test",

+ "<link rel=preload href=bla as=style type='text/bla'>", nullptr,

+ "http://example.test/", Resource::CSSStyleSheet, 0},

{"http://example.test", "<link rel=preload href=bla as=image>", "bla",

"http://example.test/", Resource::Image, 0},

+ {"http://example.test",

+ "<link rel=preload href=bla as=image type='image/webp'>", "bla",

+ "http://example.test/", Resource::Image, 0},

+ {"http://example.test",

+ "<link rel=preload href=bla as=image type='image/bla'>", nullptr,

+ "http://example.test/", Resource::Image, 0},

{"http://example.test", "<link rel=preload href=bla as=font>", "bla",

"http://example.test/", Resource::Font, 0},

+ {"http://example.test",

+ "<link rel=preload href=bla as=font type='font/woff2'>", "bla",

+ "http://example.test/", Resource::Font, 0},

+ {"http://example.test",

+ "<link rel=preload href=bla as=font type='font/bla'>", nullptr,

+ "http://example.test/", Resource::Font, 0},

{"http://example.test", "<link rel=preload href=bla as=media>", "bla",

"http://example.test/", Resource::Media, 0},

{"http://example.test", "<link rel=preload href=bla as=track>", "bla",