Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2620953002: [wasm][asm.js] Exclude zero left hand side in arm64 isel. (Closed)

Created:
3 years, 11 months ago by bradnelson
Modified:
3 years, 11 months ago
Reviewers:
titzer, bradn, rossberg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Exclude zero left hand side in arm64 isel. BUG=641885 R=titzer@chromium.org,rossberg@chromium.org Review-Url: https://codereview.chromium.org/2620953002 Cr-Commit-Position: refs/heads/master@{#42190} Committed: https://chromium.googlesource.com/v8/v8/+/e8188a2d9977815ad84483a5721d1f70eea2e903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/asm/regress-641885.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
bradn
3 years, 11 months ago (2017-01-10 08:20:28 UTC) #4
titzer
lgtm
3 years, 11 months ago (2017-01-10 09:35:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620953002/1
3 years, 11 months ago (2017-01-10 17:44:35 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 17:46:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e8188a2d9977815ad84483a5721d1f70eea...

Powered by Google App Engine
This is Rietveld 408576698