Test that OmniboxViewViews has opaque background.

chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

Index: chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
index acb72528c2c73cc3562358dccdf152b05c6c961f..6571a76cb4d08ef92d855f2a0a98fbfd51867809 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
@@ -233,3 +233,11 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewViewsTest, SelectAllOnTabToFocus) {
   EXPECT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX));
   EXPECT_TRUE(omnibox_view->IsSelectAll());
 }
+
+IN_PROC_BROWSER_TEST_F(OmniboxViewViewsTest, BackgroundIsOpaque) {
+  // The omnibox text should be rendered on an opaque background. Otherwise,
+  // Chrome OS is unable to use subpixel rendering: http://crbug.com/233364

[Peter Kasting, 2014/05/07 18:48:51]

Nit: I'd just change this whole line to "we can't use subpixel rendering." and
drop the bug reference.

[Daniel Erat, 2014/05/07 23:12:36]

Done.

+  OmniboxView* view = browser()->window()->GetLocationBar()->GetOmniboxView();
+  EXPECT_FALSE(static_cast<OmniboxViewViews*>(view)->GetRenderText()->

[Peter Kasting, 2014/05/07 18:48:51]

Nit: We can avoid this cast if we use something like
BrowserWindowTesting::GetLocationBarView()->omnibox_view().  (That's assuming
the browser window here is actually a BrowserWindowTesting that you can get a
handle to somehow.)

[Daniel Erat, 2014/05/07 23:12:36]

this seems to be the case. i've added in some ASSERT_TRUEs to crash a bit more
gracefully than a segfault if the implementation changes in the future such that
this becomes something other than a BrowserWindowTesting.

+      background_is_transparent());
+}