Test that OmniboxViewViews has opaque background.

chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/omnibox/omnibox_view_views.h"
 
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/omnibox/location_bar.h"
@@ skipping 215 matching lines @@
   EXPECT_FALSE(omnibox_view->IsSelectAll());
 
   // Pressing tab to focus the omnibox should select all text.
   while (!ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX)) {
     ASSERT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_TAB,
                                                 false, false, false, false));
   }
   EXPECT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX));
   EXPECT_TRUE(omnibox_view->IsSelectAll());
 }
+
+IN_PROC_BROWSER_TEST_F(OmniboxViewViewsTest, BackgroundIsOpaque) {
+  // The omnibox text should be rendered on an opaque background. Otherwise,
+  // Chrome OS is unable to use subpixel rendering: http://crbug.com/233364

[Peter Kasting, 2014/05/07 18:48:51]

Nit: I'd just change this whole line to "we can't use subpixel rendering." and
drop the bug reference.

[Daniel Erat, 2014/05/07 23:12:36]

Done.

+  OmniboxView* view = browser()->window()->GetLocationBar()->GetOmniboxView();
+  EXPECT_FALSE(static_cast<OmniboxViewViews*>(view)->GetRenderText()->

[Peter Kasting, 2014/05/07 18:48:51]

Nit: We can avoid this cast if we use something like
BrowserWindowTesting::GetLocationBarView()->omnibox_view().  (That's assuming
the browser window here is actually a BrowserWindowTesting that you can get a
handle to somehow.)

[Daniel Erat, 2014/05/07 23:12:36]

this seems to be the case. i've added in some ASSERT_TRUEs to crash a bit more
gracefully than a segfault if the implementation changes in the future such that
this becomes something other than a BrowserWindowTesting.

+      background_is_transparent());
+}