Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: Source/core/html/HTMLFormControlElement.cpp

Issue 262093006: Oilpan: Make the Node hierarchy RefCountedGarbageCollected instead of TreeShared. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Another build fix. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLFormControlElement.cpp
diff --git a/Source/core/html/HTMLFormControlElement.cpp b/Source/core/html/HTMLFormControlElement.cpp
index cdb8c28879ab7bee58146cd00ae2c31a6ea90024..9bc9d1d066208c6f0da2f899a2b25720ddcf877d 100644
--- a/Source/core/html/HTMLFormControlElement.cpp
+++ b/Source/core/html/HTMLFormControlElement.cpp
@@ -65,6 +65,7 @@ HTMLFormControlElement::~HTMLFormControlElement()
{
#if !ENABLE(OILPAN)
setForm(0);
+ hideVisibleValidationMessage();
haraken 2014/05/06 15:59:42 tkent-san: Would you confirm that this change is O
tkent 2014/05/07 00:41:19 This line is unnecessary. One in removedFrom is e
Mads Ager (chromium) 2014/05/07 12:13:16 The question is what happens if the entire documen
tkent 2014/05/07 13:56:55 Yeah, it's right.
#endif
}
@@ -247,6 +248,7 @@ Node::InsertionNotificationRequest HTMLFormControlElement::insertedInto(Containe
void HTMLFormControlElement::removedFrom(ContainerNode* insertionPoint)
{
+ hideVisibleValidationMessage();
m_validationMessage = nullptr;
m_ancestorDisabledState = AncestorDisabledStateUnknown;
m_dataListAncestorState = Unknown;

Powered by Google App Engine
This is Rietveld 408576698