Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2620923002: Avoid runtime error for some type of entries which don't have volumeInfo. (Closed)

Created:
3 years, 11 months ago by yamaguchi
Modified:
3 years, 11 months ago
Reviewers:
fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid runtime error for some type of entries which don't have volumeInfo. Mounted ZIP files will not have destinationLocationInfo.volumeInfo field. BUG=679637 TEST=manual test as noted in the bug. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2620923002 Cr-Commit-Position: refs/heads/master@{#442535} Committed: https://chromium.googlesource.com/chromium/src/+/0be63c49d90c37d2e7de8b814589b7d90e3548ea

Patch Set 1 #

Patch Set 2 : Fix same issue in another place. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_transfer_controller.js View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
yamaguchi
ptal
3 years, 11 months ago (2017-01-10 08:26:38 UTC) #7
fukino
lgtm
3 years, 11 months ago (2017-01-10 08:30:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620923002/20001
3 years, 11 months ago (2017-01-10 08:54:04 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 08:57:42 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0be63c49d90c37d2e7de8b814589...

Powered by Google App Engine
This is Rietveld 408576698