Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2620893002: [wasm][asm.js] Ensure final validation phase runs. (Closed)

Created:
3 years, 11 months ago by bradnelson
Modified:
3 years, 11 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Ensure final validation phase runs. Asm.js modules missing exports fail to run the last phase of validation. Adding an explicit check for this. BUG=676573 R=titzer@chromium.org,aseemgarg@chromium.org Review-Url: https://codereview.chromium.org/2620893002 Cr-Commit-Position: refs/heads/master@{#42191} Committed: https://chromium.googlesource.com/v8/v8/+/b1cfa6448cd6e048b5dd55ba9726805c9221ffe1

Patch Set 1 #

Patch Set 2 : drop junk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -13 lines) Patch
M src/asmjs/asm-typer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/asmjs/asm-typer.cc View 1 2 chunks +23 lines, -13 lines 0 comments Download
M src/asmjs/asm-wasm-builder.cc View 4 chunks +12 lines, -0 lines 0 comments Download
A test/mjsunit/asm/regress-676573.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
bradnelson
3 years, 11 months ago (2017-01-10 06:32:38 UTC) #3
titzer
lgtm
3 years, 11 months ago (2017-01-10 09:44:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620893002/20001
3 years, 11 months ago (2017-01-10 17:45:05 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 17:47:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/b1cfa6448cd6e048b5dd55ba9726805c922...

Powered by Google App Engine
This is Rietveld 408576698