third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl - Issue 2620883002: Convert Settings.in, CSSValueKeywords.in, SVGCSSValueKeywords.in to json5

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl

Issue 2620883002: Convert Settings.in, CSSValueKeywords.in, SVGCSSValueKeywords.in to json5 (Closed)

Patch Set: Fix comment indent in data Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/build/scripts/name_utilities.py ('K') | « third_party/WebKit/Source/build/scripts/name_utilities.py ('k') | third_party/WebKit/Source/core/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl

index 60677760d3ee31c5dcba3633a73d13e341bb2fe6..c21f1b65b4465418fc796c59f930e24e84aea64b 100644

--- a/third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl

@@ -22,11 +22,11 @@

// End of SETTINGS_MEMBER_VARIABLES.

#define SETTINGS_INITIALIZER_LIST \

- {% for setting in settings if setting.initial and setting.type != 'bool' %}

+ {% for setting in settings if setting.initial is not none and setting.type != 'bool' %}

, m_{{setting.name}}({{setting.initial}}) \

{% endfor %}

- {% for setting in settings if setting.initial and setting.type == 'bool' %}

- , m_{{setting.name}}({{setting.initial}}) \

+ {% for setting in settings if setting.initial is not none and setting.type == 'bool' %}

+ , m_{{setting.name}}({{setting.initial|cpp_bool}}) \

{% endfor %}

// End of SETTINGS_INITIALIZER_LIST.