Convert Settings.in, CSSValueKeywords.in, SVGCSSValueKeywords.in to json5

third_party/WebKit/Source/build/scripts/name_utilities.py

Index: third_party/WebKit/Source/build/scripts/name_utilities.py
diff --git a/third_party/WebKit/Source/build/scripts/name_utilities.py b/third_party/WebKit/Source/build/scripts/name_utilities.py
index 90b80ba8cc3f0b05d588a69e89144e8a7c79ca93..892d619bfc38e6528a434b7a80f5ab41027e5a32 100644
--- a/third_party/WebKit/Source/build/scripts/name_utilities.py
+++ b/third_party/WebKit/Source/build/scripts/name_utilities.py
@@ -93,6 +93,14 @@ def script_name(entry):
     return os.path.basename(entry['name'])
 
 
+def cpp_bool(value):
+    if value is True:
+        return 'true'
+    if value is False:
+        return 'false'
+    return value

[dcheng, 2017/01/16 05:52:52]

I'm a bit surprised that this isn't just:

return 'true' if value else false

It'd be nice to document why it needs to return the original value as-is.

[ktyliu, 2017/01/16 06:19:56]

Added comment pointing out it can be a platform-dependent const such as
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Set...

+
+
 def cpp_name(entry):
     return entry['ImplementedAs'] or script_name(entry)