Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2620843003: Remove bogus format specifier "%s" in logging in BuildInfo.java. (Closed)

Created:
3 years, 11 months ago by kinaba
Modified:
3 years, 11 months ago
Reviewers:
BigBossZhiling, Torne
CC:
chromium-reviews, agrieve+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove bogus format specifier "%s" in logging in BuildInfo.java. android.util.Log does not take formatted string (the third argument is a fixed overload taking a Throwable object), so currently the bare "%s" is emit to the log. Let's drop it. BUG=none Review-Url: https://codereview.chromium.org/2620843003 Cr-Commit-Position: refs/heads/master@{#442788} Committed: https://chromium.googlesource.com/chromium/src/+/04a7d729155baecab68fde4bedac49d5a1d1e9aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/android/java/src/org/chromium/base/BuildInfo.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
kinaba
PTAL: torne@ hzl@ This is harmless but was a bit confusing and scary to see ...
3 years, 11 months ago (2017-01-10 07:28:54 UTC) #6
Torne
lgtm
3 years, 11 months ago (2017-01-10 10:45:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620843003/1
3 years, 11 months ago (2017-01-11 03:47:57 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 04:05:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/04a7d729155baecab68fde4bedac...

Powered by Google App Engine
This is Rietveld 408576698