Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2620823002: DevTools: extract the dom_extension module. (Closed)

Created:
3 years, 11 months ago by pfeldman
Modified:
3 years, 11 months ago
Reviewers:
dgozman, pfeldman1
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: extract the dom_extension module. BUG=679551 Review-Url: https://codereview.chromium.org/2620823002 Cr-Commit-Position: refs/heads/master@{#442651} Committed: https://chromium.googlesource.com/chromium/src/+/cf853f861018bf40bb283f50f12cade69db0091e

Patch Set 1 #

Patch Set 2 : fixed tests #

Patch Set 3 : rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -818 lines) Patch
M third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt View 1 2 5 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/open-with-rendering-option-enabled-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 2 2 chunks +2 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/dom_extension/DOMExtension.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/dom_extension/module.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/inspector.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/toolbox.json View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/toolbox_bootstrap/module.json View 1 chunk +2 lines, -1 line 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/DOMExtension.js View 1 chunk +0 lines, -814 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/module.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/unit_test_runner.json View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
pfeldman
3 years, 11 months ago (2017-01-10 01:17:20 UTC) #2
dgozman
lgtm
3 years, 11 months ago (2017-01-10 01:19:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620823002/20001
3 years, 11 months ago (2017-01-10 01:55:26 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on ...
3 years, 11 months ago (2017-01-10 03:56:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620823002/20001
3 years, 11 months ago (2017-01-10 04:42:23 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/367655)
3 years, 11 months ago (2017-01-10 05:20:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620823002/40001
3 years, 11 months ago (2017-01-10 17:17:55 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 19:17:13 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cf853f861018bf40bb283f50f12c...

Powered by Google App Engine
This is Rietveld 408576698