[chromedriver] Use nodeType instead of instanceof.

[chromedriver] Use nodeType instead of instanceof.

For some reason, some pages redefine window.Element, which breaks our previous
use of instanceof.

BUG=chromedriver:1388
Review-Url: https://codereview.chromium.org/2620803002
Cr-Commit-Position: refs/heads/master@{#443405}
Committed: https://chromium.googlesource.com/chromium/src/+/dea291aa30b95a0d81e2ac1d2661c1d93061c5a4

[samuong, 2017-01-12 20:25:50]

Some users have reported errors when finding elements, and after some
investigation it turns out that many pages override window.Element. This breaks
our use of "value instanceof Element" in the wrap() function. So I've worked
around this by checking by looking at nodeType instead. PTAL?

[samuong, 2017-01-12 20:26:04]

samuong@chromium.org changed reviewers:
+ stgao@chromium.org

[stgao, 2017-01-12 23:37:28]

Interesting use cases.

LGTM

[samuong, 2017-01-12 23:51:38]

The CQ bit was checked by samuong@chromium.org

[commit-bot: I haz the power, 2017-01-12 23:53:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 00:18:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484265098948020, "parent_rev":
"2135a640a1547f44b62828bac84dc713d39652c6", "commit_rev":
"dea291aa30b95a0d81e2ac1d2661c1d93061c5a4"}

[commit-bot: I haz the power, 2017-01-13 00:19:05]

Description was changed from

==========
[chromedriver] Use nodeType instead of instanceof.

For some reason, some pages redefine window.Element, which breaks our previous
use of instanceof.

BUG=chromedriver:1388
==========

to

==========
[chromedriver] Use nodeType instead of instanceof.

For some reason, some pages redefine window.Element, which breaks our previous
use of instanceof.

BUG=chromedriver:1388

Review-Url: https://codereview.chromium.org/2620803002
Cr-Commit-Position: refs/heads/master@{#443405}
Committed:
https://chromium.googlesource.com/chromium/src/+/dea291aa30b95a0d81e2ac1d2661...
==========

[commit-bot: I haz the power, 2017-01-13 00:19:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dea291aa30b95a0d81e2ac1d2661...

[PhistucK, 2017-01-13 09:15:40]

phistuck@gmail.com changed reviewers:
+ phistuck@gmail.com

[PhistucK, 2017-01-13 09:15:40]

https://codereview.chromium.org/2620803002/diff/1/chrome/test/chromedriver/js...
File chrome/test/chromedriver/js/call_function.js (right):

https://codereview.chromium.org/2620803002/diff/1/chrome/test/chromedriver/js...
chrome/test/chromedriver/js/call_function.js:264: value.nodeType ==
Node.ELEMENT_NODE)) {
For consistency, I think you should use the above defined NodeType.ELEMENT (and
below used).
This has the benefit of not breaking in case Node is also redefined.

[samuong, 2017-01-13 18:26:42]

https://codereview.chromium.org/2620803002/diff/1/chrome/test/chromedriver/js...
File chrome/test/chromedriver/js/call_function.js (right):

https://codereview.chromium.org/2620803002/diff/1/chrome/test/chromedriver/js...
chrome/test/chromedriver/js/call_function.js:264: value.nodeType ==
Node.ELEMENT_NODE)) {
On 2017/01/13 09:15:40, PhistucK wrote:
> For consistency, I think you should use the above defined NodeType.ELEMENT
(and
> below used).
> This has the benefit of not breaking in case Node is also redefined.

Sounds reasonable, I've created https://codereview.chromium.org/2629403003/ for
this. Thanks!