Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 2620793002: [Devtools] Clear cache before running the test (Closed)

Created:
3 years, 11 months ago by allada
Modified:
3 years, 11 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Clear cache before running the test This should help reducing the flakiness of this test, which is currently ~65%: http://test-results.appspot.com/flakiness/dir/http/tests/inspector/network. The text diff shows that actual number of items that are cached is different from the expected: https://justpaste.it/11bq3. R=allada@chromium.org BUG=673378, 678486 patch from issue 2570553002 at patchset 180001 (http://crrev.com/2570553002#ps180001) Review-Url: https://codereview.chromium.org/2620793002 Cr-Commit-Position: refs/heads/master@{#442663} Committed: https://chromium.googlesource.com/chromium/src/+/1b1f643260924f93e19015e44ac61c97190e64b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters.html View 2 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
allada
PTL. sergiyb@ This didnt upload last time because dgozman@ sent a patch a couple weeks ...
3 years, 11 months ago (2017-01-09 23:47:46 UTC) #2
Sergiy Byelozyorov
lgtm
3 years, 11 months ago (2017-01-10 08:01:55 UTC) #3
Sergiy Byelozyorov
On 2017/01/09 23:47:46, allada wrote: > PTL. > > sergiyb@ This didnt upload last time ...
3 years, 11 months ago (2017-01-10 08:04:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620793002/1
3 years, 11 months ago (2017-01-10 18:26:17 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 19:48:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1b1f643260924f93e19015e44ac6...

Powered by Google App Engine
This is Rietveld 408576698