[Android] Fix bugs for menu item display in CCT

[Android] Fix bugs for menu item display in CCT

Fix several bugs related to the menu items displayed in CCT, including:
1. The text message shown on the snackbar for bookmarked page is
incorrect. Current text message displayed is "Open in [Chrome Dev]" and
the correct one should be "Bookmarked in [Chrome Dev"].
2. "Find in page", "Add to Home screen",  "Request desktop site" and
"Open in browser" items should not be displayed in Media Viewer CCT.
Hide these items if it is Media Viewer and also add a test case for it.
3. Disable download item if CCT loads a chrome native page.

BUG=679255, 679256
Review-Url: https://codereview.chromium.org/2620763004
Cr-Commit-Position: refs/heads/master@{#442638}
Committed: https://chromium.googlesource.com/chromium/src/+/0a91e531b7f77bc2111e46c59f5e0d03afa1ffca

[ltian, 2017-01-09 22:32:53]

The CQ bit was checked by ltian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 22:33:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 23:31:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 23:31:27]

Dry run: This issue passed the CQ dry run.

[ltian, 2017-01-10 00:03:38]

ltian@chromium.org changed reviewers:
+ tedchoc@chromium.org

[ltian, 2017-01-10 00:03:38]

tedchoc@chromium.org: can you take a look about my changes in this CL?

Thanks!

[Ted C, 2017-01-10 00:55:59]

https://codereview.chromium.org/2620763004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
(right):

https://codereview.chromium.org/2620763004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java:116:
addToHomeScreenItem.setVisible(false);
we likely want to disable download and bookmark for these as well.

ahh, I guess download is likely handled below.

I think we should disable bookmark in this case as well.

[ltian, 2017-01-10 01:08:13]

https://codereview.chromium.org/2620763004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
(right):

https://codereview.chromium.org/2620763004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java:116:
addToHomeScreenItem.setVisible(false);
On 2017/01/10 00:55:59, Ted C wrote:
> we likely want to disable download and bookmark for these as well.
> 
> ahh, I guess download is likely handled below.
> 
> I think we should disable bookmark in this case as well.

I think for both download and bookmark and all other icon menus (like reload and
info), they are disabled by iconRow.setVisible(false); because they are grouped
into the icon_row_menu_id item.

[Ted C, 2017-01-10 17:24:05]

lgtm

https://codereview.chromium.org/2620763004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
(right):

https://codereview.chromium.org/2620763004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java:116:
addToHomeScreenItem.setVisible(false);
On 2017/01/10 01:08:13, ltian wrote:
> On 2017/01/10 00:55:59, Ted C wrote:
> > we likely want to disable download and bookmark for these as well.
> > 
> > ahh, I guess download is likely handled below.
> > 
> > I think we should disable bookmark in this case as well.
> 
> I think for both download and bookmark and all other icon menus (like reload
and
> info), they are disabled by iconRow.setVisible(false); because they are
grouped
> into the icon_row_menu_id item.

Ah ha!  Indeed!  Sorry about that.

[ltian, 2017-01-10 18:42:59]

The CQ bit was checked by ltian@chromium.org

[commit-bot: I haz the power, 2017-01-10 18:43:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 18:48:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484073779650960, "parent_rev":
"5c61d124a2b14a963c7169359a99a9d2e5bdf560", "commit_rev":
"0a91e531b7f77bc2111e46c59f5e0d03afa1ffca"}

[commit-bot: I haz the power, 2017-01-10 18:48:47]

Description was changed from

==========
[Android] Fix bugs for menu item display in CCT

Fix several bugs related to the menu items displayed in CCT, including:
1. The text message shown on the snackbar for bookmarked page is
incorrect. Current text message displayed is "Open in [Chrome Dev]" and
the correct one should be "Bookmarked in [Chrome Dev"].
2. "Find in page", "Add to Home screen",  "Request desktop site" and
"Open in browser" items should not be displayed in Media Viewer CCT.
Hide these items if it is Media Viewer and also add a test case for it.
3. Disable download item if CCT loads a chrome native page.

BUG=679255,679256
==========

to

==========
[Android] Fix bugs for menu item display in CCT

Fix several bugs related to the menu items displayed in CCT, including:
1. The text message shown on the snackbar for bookmarked page is
incorrect. Current text message displayed is "Open in [Chrome Dev]" and
the correct one should be "Bookmarked in [Chrome Dev"].
2. "Find in page", "Add to Home screen",  "Request desktop site" and
"Open in browser" items should not be displayed in Media Viewer CCT.
Hide these items if it is Media Viewer and also add a test case for it.
3. Disable download item if CCT loads a chrome native page.

BUG=679255,679256

Review-Url: https://codereview.chromium.org/2620763004
Cr-Commit-Position: refs/heads/master@{#442638}
Committed:
https://chromium.googlesource.com/chromium/src/+/0a91e531b7f77bc2111e46c59f5e...
==========

[commit-bot: I haz the power, 2017-01-10 18:48:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0a91e531b7f77bc2111e46c59f5e...