Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Unified Diff: src/type-feedback-vector.cc

Issue 2620753003: [TypeFeedbackVector] Root literal arrays in function literals slots (Closed)
Patch Set: Compile fix. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/type-feedback-vector.cc
diff --git a/src/type-feedback-vector.cc b/src/type-feedback-vector.cc
index c5908c717b40f7964381fab7579947d00ece39fa..4e56ffd8c47ac6049e76fcb2d6778990c68dd8ad 100644
--- a/src/type-feedback-vector.cc
+++ b/src/type-feedback-vector.cc
@@ -252,10 +252,8 @@ Handle<TypeFeedbackVector> TypeFeedbackVector::New(
// the empty literals array here.
array->set(index, *factory->empty_literals_array(), SKIP_WRITE_BARRIER);
} else {
- // TODO(mvstanton): Create the array.
- // Handle<FixedArray> value = factory->NewFixedArray(length);
- // array->set(index, *value);
- array->set(index, *factory->empty_literals_array(), SKIP_WRITE_BARRIER);
+ Handle<FixedArray> value = factory->NewFixedArray(length);
+ array->set(index, *value);
}
}
i += entry_size;
@@ -378,6 +376,7 @@ void TypeFeedbackVector::ClearSlotsImpl(SharedFunctionInfo* shared,
case FeedbackVectorSlotKind::CREATE_CLOSURE: {
// Fill the array with undefined.
FixedArray* array = FixedArray::cast(Get(slot));
+ // TODO(mvstanton): explain the 1 below!
for (int i = 1; i < array->length(); i++) {
array->set_undefined(i);
}

Powered by Google App Engine
This is Rietveld 408576698