[TypeFeedbackVector] Root literal arrays in function literals slots

src/type-feedback-vector.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/type-feedback-vector.h"
 
 #include "src/code-stubs.h"
 #include "src/ic/ic-inl.h"
 #include "src/ic/ic-state.h"
 #include "src/objects.h"
@@ skipping 234 matching lines @@
     int entry_size = TypeFeedbackMetadata::GetSlotSize(kind);
 
     if (kind == FeedbackVectorSlotKind::CREATE_CLOSURE) {
       // This fixed array is filled with undefined.
       int length = metadata->GetParameter(parameter_index++);
       if (length == 0) {
         // This is a native function literal. We can always point to
         // the empty literals array here.
         array->set(index, *factory->empty_literals_array(), SKIP_WRITE_BARRIER);
       } else {
-        // TODO(mvstanton): Create the array.
-        // Handle<FixedArray> value = factory->NewFixedArray(length);
-        // array->set(index, *value);
-        array->set(index, *factory->empty_literals_array(), SKIP_WRITE_BARRIER);
+        Handle<FixedArray> value = factory->NewFixedArray(length);
+        array->set(index, *value);
       }
     }
     i += entry_size;
   }
 
   DisallowHeapAllocation no_gc;
 
   // Ensure we can skip the write barrier
   Handle<Object> uninitialized_sentinel = UninitializedSentinel(isolate);
   DCHECK_EQ(isolate->heap()->uninitialized_symbol(), *uninitialized_sentinel);
@@ skipping 102 matching lines @@
         case FeedbackVectorSlotKind::INTERPRETER_BINARYOP_IC:
         case FeedbackVectorSlotKind::INTERPRETER_COMPARE_IC: {
           DCHECK(Get(slot)->IsSmi());
           // don't clear these smi slots.
           // Set(slot, Smi::kZero);
           break;
         }
         case FeedbackVectorSlotKind::CREATE_CLOSURE: {
           // Fill the array with undefined.
           FixedArray* array = FixedArray::cast(Get(slot));
+          // TODO(mvstanton): explain the 1 below!
           for (int i = 1; i < array->length(); i++) {
             array->set_undefined(i);
           }
           break;
         }
         case FeedbackVectorSlotKind::GENERAL: {
           if (obj->IsHeapObject()) {
             InstanceType instance_type =
                 HeapObject::cast(obj)->map()->instance_type();
             // AllocationSites are exempt from clearing. They don't store Maps
@@ skipping 698 matching lines @@
 void StoreDataPropertyInLiteralICNexus::ConfigureMonomorphic(
     Handle<Name> name, Handle<Map> receiver_map) {
   Handle<WeakCell> cell = Map::WeakCellForMap(receiver_map);
 
   SetFeedback(*cell);
   SetFeedbackExtra(*name);
 }
 
 }  // namespace internal
 }  // namespace v8