Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Issue 2620653003: Add ScopedTaskScheduler in video_decode_accelerator_unittest.cc. (Closed)

Created:
3 years, 11 months ago by fdoray
Modified:
3 years, 11 months ago
Reviewers:
Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ScopedTaskScheduler in video_decode_accelerator_unittest.cc. This is needed for the call to base::PostTaskWithTraits in ui::DrmDisplayHostManager::ProcessEvent. BUG=678598 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2620653003 Cr-Commit-Position: refs/heads/master@{#442898} Committed: https://chromium.googlesource.com/chromium/src/+/dffd09b3dc86444afa5b91f90a1267bc7d133839

Patch Set 1 #

Patch Set 2 : self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M media/gpu/video_decode_accelerator_unittest.cc View 1 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
fdoray
In tests, a base::test::ScopedTaskScheduler is required to call functions in base/task_scheduler/post_task.h. This CL should fix ...
3 years, 11 months ago (2017-01-09 15:15:19 UTC) #5
Pawel Osciak
Thanks, tested on CrOS and this appears to fix the problem. lgtm
3 years, 11 months ago (2017-01-11 02:18:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620653003/20001
3 years, 11 months ago (2017-01-11 13:25:24 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 14:28:13 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dffd09b3dc86444afa5b91f90a12...

Powered by Google App Engine
This is Rietveld 408576698