Remove mojo::edk::test::ScopedIPCSupport

Remove mojo::edk::test::ScopedIPCSupport

ScopedIPCSupport has two separate and subtly different implementations:
mojo::edk::test::ScopedIPCSupport for test-only use, and
mojo::edk::ScopedIPCSupport for general-purpose use.

This unifies them into a much simpler general-purpose ScopedIPCSupport
implementation suitable for all practical environments.

Also removes mojo::edk::ProcessDelegate, as it is abstraction overkill.
Instead of InitIPCSupport taking a ProcessDelegate which goes unused
until shutdown, ShutdownIPCSupport now simply takes a callback to be run
upon completion.

BUG=None
R=jam@chromium.org
TBR=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2620633004
Cr-Commit-Position: refs/heads/master@{#443539}
Committed: https://chromium.googlesource.com/chromium/src/+/e5180e0e70f6511ec6f1398ad177e6d870232667

[Ken Rockot(use gerrit already), 2017-01-10 01:13:17]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 01:14:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 01:21:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 01:21:48]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ken Rockot(use gerrit already), 2017-01-11 00:50:53]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 00:51:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 00:56:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 00:56:58]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Ken Rockot(use gerrit already), 2017-01-11 19:25:36]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2017-01-11 19:26:38]

Description was changed from

==========
Remove mojo::edk::test::ScopedIPCSupport

ScopedIPCSupport has two separate and subtly different implementations:
mojo::edk::test::ScopedIPCSupport for test-only use, and
mojo::edk::ScopedIPCSupport for general-purpose use. The test-only
implementation is strictly more correct because it enforces clean
EDK shutdown.

This merges the better test-only implementation into the general-purpose
implementation to eliminate the confusing duplication.

Also removes mojo::edk::ProcessDelegate as it's overkill. Instead of
InitIPCSupport taking a ProcessDelegate which goes unused until shutdown,
ShutdownIPCSupport takes a callback to be run upon completion.

BUG=None
R=jam@chromium.org
==========

to

==========
Remove mojo::edk::test::ScopedIPCSupport

ScopedIPCSupport has two separate and subtly different implementations:
mojo::edk::test::ScopedIPCSupport for test-only use, and
mojo::edk::ScopedIPCSupport for general-purpose use. The test-only
implementation is strictly more correct because it enforces clean
EDK shutdown.

This merges the better test-only implementation into the general-purpose
implementation to eliminate the confusing duplication.

Also removes mojo::edk::ProcessDelegate, as it is abstraction overkill.
Instead of InitIPCSupport taking a ProcessDelegate which goes unused
until shutdown, ShutdownIPCSupport now simply takes a callback to be run
upon completion.

BUG=None
R=jam@chromium.org
==========

[commit-bot: I haz the power, 2017-01-11 19:26:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 19:33:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 19:33:39]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2017-01-11 20:32:37]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 20:33:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 20:50:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:50:44]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2017-01-11 20:55:39]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 20:56:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 21:50:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 21:50:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2017-01-12 00:53:24]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 00:54:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-01-12 00:55:20]

Description was changed from

==========
Remove mojo::edk::test::ScopedIPCSupport

ScopedIPCSupport has two separate and subtly different implementations:
mojo::edk::test::ScopedIPCSupport for test-only use, and
mojo::edk::ScopedIPCSupport for general-purpose use. The test-only
implementation is strictly more correct because it enforces clean
EDK shutdown.

This merges the better test-only implementation into the general-purpose
implementation to eliminate the confusing duplication.

Also removes mojo::edk::ProcessDelegate, as it is abstraction overkill.
Instead of InitIPCSupport taking a ProcessDelegate which goes unused
until shutdown, ShutdownIPCSupport now simply takes a callback to be run
upon completion.

BUG=None
R=jam@chromium.org
==========

to

==========
Remove mojo::edk::test::ScopedIPCSupport

ScopedIPCSupport has two separate and subtly different implementations:
mojo::edk::test::ScopedIPCSupport for test-only use, and
mojo::edk::ScopedIPCSupport for general-purpose use.

This unifies them into a much simpler general-purpose ScopedIPCSupport
implementation suitable for all practical environments.

Also removes mojo::edk::ProcessDelegate, as it is abstraction overkill.
Instead of InitIPCSupport taking a ProcessDelegate which goes unused
until shutdown, ShutdownIPCSupport now simply takes a callback to be run
upon completion.

BUG=None
R=jam@chromium.org
==========

[Ken Rockot(use gerrit already), 2017-01-12 01:04:58]

PTAL as mojo and general toplevel OWNER. The main point of interest here is that
I've made ScopedIPCSupport's destructor always block, and thus added an
exception to ScopedAllowWait. Most of the other changes here are fairly
mechanical.

[Ken Rockot(use gerrit already), 2017-01-12 01:05:16]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 01:05:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-01-12 01:06:35]

Patchset #1 (id:1) has been deleted

[Ken Rockot(use gerrit already), 2017-01-12 01:06:41]

Patchset #1 (id:20001) has been deleted

[Ken Rockot(use gerrit already), 2017-01-12 01:06:47]

Patchset #1 (id:40001) has been deleted

[Ken Rockot(use gerrit already), 2017-01-12 01:06:54]

Patchset #1 (id:60001) has been deleted

[Ken Rockot(use gerrit already), 2017-01-12 01:07:00]

Patchset #1 (id:80001) has been deleted

[Ken Rockot(use gerrit already), 2017-01-12 01:07:06]

Patchset #1 (id:100001) has been deleted

[commit-bot: I haz the power, 2017-01-12 03:20:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 03:20:59]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2017-01-12 21:27:56]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 21:28:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-01-12 21:29:06]

Per our offline discussion, I've made clean shutdown optional.

I chose to make the decision explicit rather than specify an arbitrary default.

Also removed a few uses of ScopedIPCSupport in test runners where IPC support
isn't needed.

[Ken Rockot(use gerrit already), 2017-01-12 21:33:54]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 21:34:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-01-12 22:11:50]

lgtm with comment updates we discussed

[Ken Rockot(use gerrit already), 2017-01-12 23:37:58]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 23:38:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-01-12 23:45:20]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 23:45:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-01-12 23:52:31]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 23:52:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 04:54:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 04:54:48]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2017-01-13 06:11:02]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-01-13 06:11:03]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2620633004/#ps210001
(title: ".")

[commit-bot: I haz the power, 2017-01-13 06:11:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 06:19:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 06:19:03]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ken Rockot(use gerrit already), 2017-01-13 12:14:17]

Description was changed from

==========
Remove mojo::edk::test::ScopedIPCSupport

ScopedIPCSupport has two separate and subtly different implementations:
mojo::edk::test::ScopedIPCSupport for test-only use, and
mojo::edk::ScopedIPCSupport for general-purpose use.

This unifies them into a much simpler general-purpose ScopedIPCSupport
implementation suitable for all practical environments.

Also removes mojo::edk::ProcessDelegate, as it is abstraction overkill.
Instead of InitIPCSupport taking a ProcessDelegate which goes unused
until shutdown, ShutdownIPCSupport now simply takes a callback to be run
upon completion.

BUG=None
R=jam@chromium.org
==========

to

==========
Remove mojo::edk::test::ScopedIPCSupport

ScopedIPCSupport has two separate and subtly different implementations:
mojo::edk::test::ScopedIPCSupport for test-only use, and
mojo::edk::ScopedIPCSupport for general-purpose use.

This unifies them into a much simpler general-purpose ScopedIPCSupport
implementation suitable for all practical environments.

Also removes mojo::edk::ProcessDelegate, as it is abstraction overkill.
Instead of InitIPCSupport taking a ProcessDelegate which goes unused
until shutdown, ShutdownIPCSupport now simply takes a callback to be run
upon completion.

BUG=None
R=jam@chromium.org
TBR=haraken@chromium.org
==========

[Ken Rockot(use gerrit already), 2017-01-13 12:16:10]

+TBR haraken for change to RunAllTests.cpp since the change does not modify
behavior.

[Ken Rockot(use gerrit already), 2017-01-13 12:18:20]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2017-01-13 12:18:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 12:24:04]

CQ is committing da patch.

Bot data: {"patchset_id": 210001, "attempt_start_ts": 1484309900779660,
"parent_rev": "c3ead867afb360569076daac6ed5563405f395b4", "commit_rev":
"e5180e0e70f6511ec6f1398ad177e6d870232667"}

[commit-bot: I haz the power, 2017-01-13 12:25:18]

Description was changed from

==========
Remove mojo::edk::test::ScopedIPCSupport

ScopedIPCSupport has two separate and subtly different implementations:
mojo::edk::test::ScopedIPCSupport for test-only use, and
mojo::edk::ScopedIPCSupport for general-purpose use.

This unifies them into a much simpler general-purpose ScopedIPCSupport
implementation suitable for all practical environments.

Also removes mojo::edk::ProcessDelegate, as it is abstraction overkill.
Instead of InitIPCSupport taking a ProcessDelegate which goes unused
until shutdown, ShutdownIPCSupport now simply takes a callback to be run
upon completion.

BUG=None
R=jam@chromium.org
TBR=haraken@chromium.org
==========

to

==========
Remove mojo::edk::test::ScopedIPCSupport

ScopedIPCSupport has two separate and subtly different implementations:
mojo::edk::test::ScopedIPCSupport for test-only use, and
mojo::edk::ScopedIPCSupport for general-purpose use.

This unifies them into a much simpler general-purpose ScopedIPCSupport
implementation suitable for all practical environments.

Also removes mojo::edk::ProcessDelegate, as it is abstraction overkill.
Instead of InitIPCSupport taking a ProcessDelegate which goes unused
until shutdown, ShutdownIPCSupport now simply takes a callback to be run
upon completion.

BUG=None
R=jam@chromium.org
TBR=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2620633004
Cr-Commit-Position: refs/heads/master@{#443539}
Committed:
https://chromium.googlesource.com/chromium/src/+/e5180e0e70f6511ec6f1398ad177...
==========

[commit-bot: I haz the power, 2017-01-13 12:25:21]

Committed patchset #6 (id:210001) as
https://chromium.googlesource.com/chromium/src/+/e5180e0e70f6511ec6f1398ad177...