Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1436)

Issue 2620633003: Add missing "." in Geolocation.Header.LocationAge* histograms. (Closed)

Created:
3 years, 11 months ago by pdyson
Modified:
3 years, 11 months ago
Reviewers:
lbargu, Ted C
CC:
agrieve+watch_chromium.org, chromium-reviews, dominickn, Ilya Sherman, jdonnelly+watch_chromium.org, kcarattini
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing "." in Geolocation.Header.LocationAge* histograms. BUG=668923 Review-Url: https://codereview.chromium.org/2620633003 Cr-Commit-Position: refs/heads/master@{#442405} Committed: https://chromium.googlesource.com/chromium/src/+/9257a44a111510a6f5121e398b17b6426e93a514

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java View 1 chunk +3 lines, -3 lines 2 comments Download

Messages

Total messages: 15 (9 generated)
pdyson
Need to add "." so that these names match the names in histograms.xml.
3 years, 11 months ago (2017-01-09 03:26:37 UTC) #4
lbargu
https://codereview.chromium.org/2620633003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java File chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java (right): https://codereview.chromium.org/2620633003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java#newcode292 chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java:292: ? Long.MAX_VALUE Can we use duration = 0 for ...
3 years, 11 months ago (2017-01-09 10:12:59 UTC) #8
Ted C
lgtm
3 years, 11 months ago (2017-01-09 16:44:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620633003/1
3 years, 11 months ago (2017-01-09 23:00:54 UTC) #11
pdyson
https://codereview.chromium.org/2620633003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java File chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java (right): https://codereview.chromium.org/2620633003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java#newcode292 chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java:292: ? Long.MAX_VALUE On 2017/01/09 at 10:12:59, lbargu wrote: > ...
3 years, 11 months ago (2017-01-09 23:15:22 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 23:40:20 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9257a44a111510a6f5121e398b17...

Powered by Google App Engine
This is Rietveld 408576698