Chromium Code Reviews| Index: chrome/browser/banners/app_banner_settings_helper.cc |
| diff --git a/chrome/browser/banners/app_banner_settings_helper.cc b/chrome/browser/banners/app_banner_settings_helper.cc |
| index f314a0c804ea8263f0a0088e6fc3cde25fa20520..2898939505149379e8381e3ca499f0e0f23250d2 100644 |
| --- a/chrome/browser/banners/app_banner_settings_helper.cc |
| +++ b/chrome/browser/banners/app_banner_settings_helper.cc |
| @@ -246,12 +246,6 @@ InstallableStatusCode AppBannerSettingsHelper::ShouldShowBanner( |
| const GURL& origin_url, |
| const std::string& package_name_or_start_url, |
| base::Time time) { |
| - // Ignore all checks if the flag to do so is set. |
| - if (base::CommandLine::ForCurrentProcess()->HasSwitch( |
|
dominickn
2017/01/10 22:51:59
This is covered by AppBannerSettingsHelper::HasSuf
|
| - switches::kBypassAppBannerEngagementChecks)) { |
| - return NO_ERROR_DETECTED; |
| - } |
| - |
| // Never show a banner when the package name or URL is empty. |
| if (package_name_or_start_url.empty()) |
| return PACKAGE_NAME_OR_START_URL_EMPTY; |
| @@ -277,9 +271,8 @@ InstallableStatusCode AppBannerSettingsHelper::ShouldShowBanner( |
| base::Time shown_time = |
| GetSingleBannerEvent(web_contents, origin_url, package_name_or_start_url, |
| APP_BANNER_EVENT_DID_SHOW); |
| - if (time - shown_time < base::TimeDelta::FromDays(gDaysAfterIgnoredToShow)) { |
| + if (time - shown_time < base::TimeDelta::FromDays(gDaysAfterIgnoredToShow)) |
| return PREVIOUSLY_IGNORED; |
| - } |
| return NO_ERROR_DETECTED; |
| } |