Check if a PWA is installed before checking the service worker and icon.

chrome/browser/banners/app_banner_settings_helper.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/banners/app_banner_settings_helper.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
@@ skipping 228 matching lines @@
   // spamminess.
   if (event == APP_BANNER_EVENT_DID_ADD_TO_HOMESCREEN)
     settings->FlushLossyWebsiteSettings();
 }
 
 InstallableStatusCode AppBannerSettingsHelper::ShouldShowBanner(
     content::WebContents* web_contents,
     const GURL& origin_url,
     const std::string& package_name_or_start_url,
     base::Time time) {
-  // Ignore all checks if the flag to do so is set.
-  if (base::CommandLine::ForCurrentProcess()->HasSwitch(

[dominickn, 2017/01/10 22:51:59]

This is covered by AppBannerSettingsHelper::HasSufficientEngagement() and
AppBannerManager::IsDebugMode().

-          switches::kBypassAppBannerEngagementChecks)) {
-    return NO_ERROR_DETECTED;
-  }
-
   // Never show a banner when the package name or URL is empty.
   if (package_name_or_start_url.empty())
     return PACKAGE_NAME_OR_START_URL_EMPTY;
 
   // Don't show if it has been added to the homescreen.
   base::Time added_time =
       GetSingleBannerEvent(web_contents, origin_url, package_name_or_start_url,
                            APP_BANNER_EVENT_DID_ADD_TO_HOMESCREEN);
   if (!added_time.is_null())
     return ALREADY_INSTALLED;
 
   base::Time blocked_time =
       GetSingleBannerEvent(web_contents, origin_url, package_name_or_start_url,
                            APP_BANNER_EVENT_DID_BLOCK);
 
   // Null times are in the distant past, so the delta between real times and
   // null events will always be greater than the limits.
   if (time - blocked_time <
       base::TimeDelta::FromDays(gDaysAfterDismissedToShow)) {
     return PREVIOUSLY_BLOCKED;
   }
 
   base::Time shown_time =
       GetSingleBannerEvent(web_contents, origin_url, package_name_or_start_url,
                            APP_BANNER_EVENT_DID_SHOW);
-  if (time - shown_time < base::TimeDelta::FromDays(gDaysAfterIgnoredToShow)) {
+  if (time - shown_time < base::TimeDelta::FromDays(gDaysAfterIgnoredToShow))
     return PREVIOUSLY_IGNORED;
-  }
 
   return NO_ERROR_DETECTED;
 }
 
 base::Time AppBannerSettingsHelper::GetSingleBannerEvent(
     content::WebContents* web_contents,
     const GURL& origin_url,
     const std::string& package_name_or_start_url,
     AppBannerEvent event) {
   DCHECK(event < APP_BANNER_EVENT_NUM_EVENTS);
@@ skipping 113 matching lines @@
   unsigned int language_option = 0;
 
   if (param.empty() || !base::StringToUint(param, &language_option) ||
       language_option < LANGUAGE_OPTION_MIN ||
       language_option > LANGUAGE_OPTION_MAX) {
     return LANGUAGE_OPTION_DEFAULT;
   }
 
   return static_cast<LanguageOption>(language_option);
 }