Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2620613003: MD History: Replace px-based font sizes with %-based sizing (Closed)

Created:
3 years, 11 months ago by tsergeant
Modified:
3 years, 11 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Replace px-based font sizes with %-based sizing This ensures that the fonts scale correctly when the browser text size is changed. BUG=670628 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2620613003 Cr-Commit-Position: refs/heads/master@{#442452} Committed: https://chromium.googlesource.com/chromium/src/+/cc6d72eadc3673ae9b0a45ec680242c89ab7f2af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -29 lines) Patch
M chrome/browser/resources/md_history/app.vulcanized.html View 17 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/resources/md_history/history_toolbar.html View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/lazy_load.crisper.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/lazy_load.vulcanized.html View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/md_history/shared_style.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/side_bar.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
tsergeant
PTAL, thanks
3 years, 11 months ago (2017-01-09 05:56:11 UTC) #5
Dan Beam
lgtm
3 years, 11 months ago (2017-01-10 01:19:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620613003/1
3 years, 11 months ago (2017-01-10 01:59:18 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 02:39:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cc6d72eadc3673ae9b0a45ec6802...

Powered by Google App Engine
This is Rietveld 408576698