handle configuration variables longer than 30 characters long

handle configuration variables longer than 30 characters long

BUG=
R=bsalomon@google.com, halcanary@google.com, reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=11757

[humper, 2013-10-14 14:05:55]

Variables longer than 30 characters are printed correctly; they just don't
nicely line up with everything else obviously.

[hal.canary, 2013-10-14 14:32:08]

lgtm, other than the nits I mentioned.

https://codereview.chromium.org/26206003/diff/1/include/utils/SkRTConf.h
File include/utils/SkRTConf.h (right):

https://codereview.chromium.org/26206003/diff/1/include/utils/SkRTConf.h#newc...
include/utils/SkRTConf.h:120: else {
"} else {" should be all on one line.

https://codereview.chromium.org/26206003/diff/1/include/utils/SkRTConf.h#newc...
include/utils/SkRTConf.h:126: sprintf(outptr+30, " %.128s",
fDescription.c_str());
Is there a style inconsistency between outptr+30 and &(outptr[30])?

[humper, 2013-10-14 15:04:27]

On 2013/10/14 14:32:08, halcanary wrote:
> lgtm, other than the nits I mentioned.
> 
> https://codereview.chromium.org/26206003/diff/1/include/utils/SkRTConf.h
> File include/utils/SkRTConf.h (right):
> 
>
https://codereview.chromium.org/26206003/diff/1/include/utils/SkRTConf.h#newc...
> include/utils/SkRTConf.h:120: else {
> "} else {" should be all on one line.
> 
>
https://codereview.chromium.org/26206003/diff/1/include/utils/SkRTConf.h#newc...
> include/utils/SkRTConf.h:126: sprintf(outptr+30, " %.128s",
> fDescription.c_str());
> Is there a style inconsistency between outptr+30 and &(outptr[30])?

Fixed first nit -- I prefer &(foo[bar]) if foo is an array, and foo+bar if foo
is a pointer, but I don't think we have official stule things on it.

Also added Mike and Brian since apparently we need Daddy to sign off on changes
in header files.

[reed1, 2013-10-14 15:07:18]

lgtm w/ concurrent nits

https://codereview.chromium.org/26206003/diff/1/include/utils/SkRTConf.h
File include/utils/SkRTConf.h (right):

https://codereview.chromium.org/26206003/diff/1/include/utils/SkRTConf.h#newc...
include/utils/SkRTConf.h:120: else {
On 2013/10/14 14:32:08, halcanary wrote:
> "} else {" should be all on one line.

agreed

https://codereview.chromium.org/26206003/diff/1/include/utils/SkRTConf.h#newc...
include/utils/SkRTConf.h:126: sprintf(outptr+30, " %.128s",
fDescription.c_str());
On 2013/10/14 14:32:08, halcanary wrote:
> Is there a style inconsistency between outptr+30 and &(outptr[30])?

very minor, but I think I agree with the reviewer, just for local consistency.
Not a strong opinion.

[bsalomon, 2013-10-14 15:08:33]

On 2013/10/14 15:04:27, humper wrote:
> On 2013/10/14 14:32:08, halcanary wrote:
> > lgtm, other than the nits I mentioned.
> > 
> > https://codereview.chromium.org/26206003/diff/1/include/utils/SkRTConf.h
> > File include/utils/SkRTConf.h (right):
> > 
> >
>
https://codereview.chromium.org/26206003/diff/1/include/utils/SkRTConf.h#newc...
> > include/utils/SkRTConf.h:120: else {
> > "} else {" should be all on one line.
> > 
> >
>
https://codereview.chromium.org/26206003/diff/1/include/utils/SkRTConf.h#newc...
> > include/utils/SkRTConf.h:126: sprintf(outptr+30, " %.128s",
> > fDescription.c_str());
> > Is there a style inconsistency between outptr+30 and &(outptr[30])?
> 
> Fixed first nit -- I prefer &(foo[bar]) if foo is an array, and foo+bar if foo
> is a pointer, but I don't think we have official stule things on it.
> 
> Also added Mike and Brian since apparently we need Daddy to sign off on
changes
> in header files.

That'll learn you not to inline. lgtm.

[humper, 2013-10-14 16:27:37]

Committed patchset #2 manually as r11757 (presubmit successful).