handle configuration variables longer than 30 characters long

include/utils/SkRTConf.h

 /*
  * Copyright 2013 Google, Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #ifndef SkRTConf_DEFINED
 #define SkRTConf_DEFINED
@@ skipping 93 matching lines @@
     T value;
     if (skRTConfRegistry().parse(fName.c_str(), &value)) {
         fValue = value;
     }
     skRTConfRegistry().registerConf(this);
 }
 
 template<typename T>
 void SkRTConf<T>::print(SkWStream *o) const {
     char outline[200]; // should be ok because we specify a max. width for everything here.
-
-    sprintf(outline, "%-30.30s", getName());
-    doPrint(&(outline[30]));
-    sprintf(&(outline[60]), " %.128s", fDescription.c_str());
+    char *outptr;
+    if (strlen(getName()) >= 30) {
+        o->writeText(getName());
+        o->writeText(" ");
+        outptr = &(outline[0]);
+    }
+    else {

[hal.canary, 2013/10/14 14:32:08]

"} else {" should be all on one line.

[reed1, 2013/10/14 15:07:18]

agreed

+        sprintf(outline, "%-30.30s", getName());
+        outptr = &(outline[30]);
+    }
+    
+    doPrint(outptr);
+    sprintf(outptr+30, " %.128s", fDescription.c_str());

[hal.canary, 2013/10/14 14:32:08]

Is there a style inconsistency between outptr+30 and &(outptr[30])?

[reed1, 2013/10/14 15:07:18]

very minor, but I think I agree with the reviewer, just for local consistency.
Not a strong opinion.

     for (size_t i = strlen(outline); i --> 0 && ' ' == outline[i];) {
         outline[i] = '\0';
     }
     o->writeText(outline);
 }
 
 template<typename T>
 void SkRTConf<T>::doPrint(char *s) const {
     sprintf(s, "%-30.30s", "How do I print myself??");
 }
@@ skipping 39 matching lines @@
     // static_cast here is okay because there's only one kind of child class.
     const SkRTConf<T> *child_pointer = static_cast<const SkRTConf<T> *>(conf);
     return child_pointer &&
            fName == child_pointer->fName &&
            fDescription == child_pointer->fDescription &&
            fValue == child_pointer->fValue &&
            fDefault == child_pointer->fDefault;
 }
 
 #endif