Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2620583002: bluetooth: Update internals page browser test fixture. (Closed)

Created:
3 years, 11 months ago by mbrunson
Modified:
3 years, 11 months ago
Reviewers:
scheib, dpapad
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Update internals page browser test fixture. With the change in the Mojo binding system, the existing test fixture is overly complex. A layer of indirection can be removed now that Mojo connections can be created with arbitrary JavaScript classes. This patch removes the TestAdapter class from bluetooth internals browser test and directly binds the TestAdapterProxy directly to an Adapter interface. BUG=651282 Review-Url: https://codereview.chromium.org/2620583002 Cr-Commit-Position: refs/heads/master@{#442116} Committed: https://chromium.googlesource.com/chromium/src/+/fa7637300e305fc861b257729e88da3cde2feaf1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -22 lines) Patch
M chrome/test/data/webui/bluetooth_internals_browsertest.js View 4 chunks +6 lines, -22 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
mbrunson
3 years, 11 months ago (2017-01-06 23:55:14 UTC) #4
scheib
LGTM
3 years, 11 months ago (2017-01-07 00:45:23 UTC) #7
dpapad
lgtm
3 years, 11 months ago (2017-01-07 00:48:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620583002/1
3 years, 11 months ago (2017-01-07 00:49:32 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-07 00:53:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fa7637300e305fc861b257729e88...

Powered by Google App Engine
This is Rietveld 408576698