binding: Changes the association among global-proxy/global/worker-instance.

binding: Changes the association among global-proxy/global/worker-instance.

Since V8 now supports internal fields for the global proxy objects,
let's change the mappings among global proxy object / global object /
C++ instance in Blink.

With this CL, a global proxy object and C++ instance point to each
other, and a global object points to the C++ instance (without
reverse pointer).

BUG=675872
Review-Url: https://codereview.chromium.org/2620493002
Cr-Commit-Position: refs/heads/master@{#443515}
Committed: https://chromium.googlesource.com/chromium/src/+/168be21d6c68f2e884d1e163edf2f9595e05ba43

[Yuki, 2017-01-06 14:21:15]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 14:21:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2017-01-06 14:59:54]

Description was changed from

==========
binding: Changes the association among global-proxy/global/worker instance.

BUG=675872
==========

to

==========
binding: Changes the association among global-proxy/global/worker-instance.

BUG=675872
==========

[commit-bot: I haz the power, 2017-01-06 16:41:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 16:41:07]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Yuki, 2017-01-11 07:59:58]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 08:00:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 09:21:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 09:21:13]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Yuki, 2017-01-11 12:36:19]

Description was changed from

==========
binding: Changes the association among global-proxy/global/worker-instance.

BUG=675872
==========

to

==========
binding: Changes the association among global-proxy/global/worker-instance.

Since V8 now supports internal fields for the global proxy objects,
let's change the mappings among global proxy object / global object /
C++ instance in Blink.

With this CL, a global proxy object and C++ instance point to each
other, and a global object points to the C++ instance (without
reverse pointer).

BUG=675872
==========

[Yuki, 2017-01-11 12:36:30]

yukishiino@chromium.org changed reviewers:
+ haraken@chromium.org

[Yuki, 2017-01-11 12:36:42]

Could you review this CL?

[haraken, 2017-01-11 12:43:53]

LGTM

https://codereview.chromium.org/2620493002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/ToV8.cpp (right):

https://codereview.chromium.org/2620493002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/ToV8.cpp:14: v8::Local<v8::Value>
ToV8(DOMWindow* window,

Are you planning to remove this in a follow-up?

https://codereview.chromium.org/2620493002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
(right):

https://codereview.chromium.org/2620493002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp:189:
//   global object       --------+

Nit: Is there any difference between <==> and <--> ?

[Yuki, 2017-01-11 12:48:28]

https://codereview.chromium.org/2620493002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/ToV8.cpp (right):

https://codereview.chromium.org/2620493002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/ToV8.cpp:14: v8::Local<v8::Value>
ToV8(DOMWindow* window,
On 2017/01/11 12:43:52, haraken wrote:
> 
> Are you planning to remove this in a follow-up?

Yes, I'm preparing a CL at
https://codereview.chromium.org/2617733004/

https://codereview.chromium.org/2620493002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
(right):

https://codereview.chromium.org/2620493002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp:189:
//   global object       --------+
On 2017/01/11 12:43:52, haraken wrote:
> 
> Nit: Is there any difference between <==> and <--> ?

It's not <-->, it's -->.

I meant <===> for two objects point to each other (bi-directional arrow), and
---> for an object points to another object (single directional arrow).

[Yuki, 2017-01-11 13:27:10]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2017-01-11 13:27:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 15:00:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 15:00:17]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Yuki, 2017-01-13 05:41:33]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2017-01-13 05:41:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 07:49:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484286093284670,
"parent_rev": "87a6ab3424caa36f6d65405f7065ca20a1b90cf2", "commit_rev":
"168be21d6c68f2e884d1e163edf2f9595e05ba43"}

[commit-bot: I haz the power, 2017-01-13 07:49:57]

Description was changed from

==========
binding: Changes the association among global-proxy/global/worker-instance.

Since V8 now supports internal fields for the global proxy objects,
let's change the mappings among global proxy object / global object /
C++ instance in Blink.

With this CL, a global proxy object and C++ instance point to each
other, and a global object points to the C++ instance (without
reverse pointer).

BUG=675872
==========

to

==========
binding: Changes the association among global-proxy/global/worker-instance.

Since V8 now supports internal fields for the global proxy objects,
let's change the mappings among global proxy object / global object /
C++ instance in Blink.

With this CL, a global proxy object and C++ instance point to each
other, and a global object points to the C++ instance (without
reverse pointer).

BUG=675872

Review-Url: https://codereview.chromium.org/2620493002
Cr-Commit-Position: refs/heads/master@{#443515}
Committed:
https://chromium.googlesource.com/chromium/src/+/168be21d6c68f2e884d1e163edf2...
==========

[commit-bot: I haz the power, 2017-01-13 07:49:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/168be21d6c68f2e884d1e163edf2...