Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 2620463002: Show service worker navigation preload requests in DevTools Network tab (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_impl.cc
diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc
index fa98d50d4485c8b9138174bf293a523d65aaecdd..bbf3b867da81fdd66b22bca32e8a490b9b9017bc 100644
--- a/content/browser/loader/resource_dispatcher_host_impl.cc
+++ b/content/browser/loader/resource_dispatcher_host_impl.cc
@@ -1501,7 +1501,8 @@ void ResourceDispatcherHostImpl::ContinuePendingBeginRequest(
ChildProcessSecurityPolicyImpl* policy =
ChildProcessSecurityPolicyImpl::GetInstance();
bool report_raw_headers = request_data.report_raw_headers;
- if (report_raw_headers && !policy->CanReadRawCookies(child_id)) {
+ if (report_raw_headers && !policy->CanReadRawCookies(child_id) &&
+ !requester_info->IsNavigationPreload()) {
falken 2017/01/17 14:38:36 Can you add a comment about why navigation preload
horo 2017/01/18 14:25:02 Done.
// TODO: crbug.com/523063 can we call bad_message::ReceivedBadMessage here?
VLOG(1) << "Denied unauthorized request for raw headers";
report_raw_headers = false;

Powered by Google App Engine
This is Rietveld 408576698