content/browser/service_worker/service_worker_fetch_dispatcher.cc - Issue 2620463002: Show service worker navigation preload requests in DevTools Network tab

Unified Diff: content/browser/service_worker/service_worker_fetch_dispatcher.cc

Issue 2620463002: Show service worker navigation preload requests in DevTools Network tab (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_fetch_dispatcher.cc

diff --git a/content/browser/service_worker/service_worker_fetch_dispatcher.cc b/content/browser/service_worker/service_worker_fetch_dispatcher.cc

index 122e931126b87a35c1a1abb0efe573ce203d995c..46a32928ea66be1d0150d9e0ba51c03247922c79 100644

--- a/content/browser/service_worker/service_worker_fetch_dispatcher.cc

+++ b/content/browser/service_worker/service_worker_fetch_dispatcher.cc

@@ -445,6 +445,8 @@ void ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload(

request.render_frame_id = original_info->GetRenderFrameID();

request.is_main_frame = original_info->IsMainFrame();

request.parent_is_main_frame = original_info->ParentIsMainFrame();

+ request.enable_load_timing = original_info->is_load_timing_enabled();

+ request.report_raw_headers = original_info->ShouldReportRawHeaders();

DCHECK(net::HttpUtil::IsValidHeaderValue(

version_->navigation_preload_state().header));

@@ -467,6 +469,11 @@ void ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload(

url_loader_factory_.associated_group());

mojom::URLLoaderAssociatedPtr url_loader_associated_ptr;

+ preload_handle_->sent_timestamp =

+ base::TimeTicks::Now().ToInternalValue() /

+ static_cast<double>(base::Time::kMicrosecondsPerSecond);

falken 2017/01/17 14:38:36 Is this converting microseconds to seconds? ToInte

horo 2017/01/18 14:25:02 Humm...I think there is no other way. There is the

+ preload_handle_->sent_wall_time = base::Time::Now().ToDoubleT();

falken 2017/01/17 14:38:36 Could we use Mojo time types instead of these, and

horo 2017/01/18 14:25:02 Done.

url_loader_factory_->CreateLoaderAndStart(

mojo::MakeRequest(&url_loader_associated_ptr,

url_loader_factory_.associated_group()),