Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2620413002: Fix various memory leaks in unit tests detected by a new version of ASAN. (Closed)

Created:
3 years, 11 months ago by rmacnak
Modified:
3 years, 11 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix various memory leaks in unit tests detected by a new version of ASAN. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/cbf3eaeb9043c335b5d16e2a7177994629ad9b1a

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -11 lines) Patch
M runtime/vm/benchmark_test.cc View 1 3 chunks +7 lines, -2 lines 0 comments Download
M runtime/vm/compiler_test.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M runtime/vm/message_handler_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/native_api_impl.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/timeline_test.cc View 6 chunks +13 lines, -1 line 0 comments Download
M runtime/vm/unit_test.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
3 years, 11 months ago (2017-01-11 19:00:06 UTC) #2
zra
lgtm https://codereview.chromium.org/2620413002/diff/1/runtime/vm/benchmark_test.cc File runtime/vm/benchmark_test.cc (right): https://codereview.chromium.org/2620413002/diff/1/runtime/vm/benchmark_test.cc#newcode101 runtime/vm/benchmark_test.cc:101: isolate_ = Dart_CreateIsolate(NULL, NULL, buffer, NULL, isolate_data, &err); ...
3 years, 11 months ago (2017-01-11 19:05:21 UTC) #3
rmacnak
https://codereview.chromium.org/2620413002/diff/1/runtime/vm/benchmark_test.cc File runtime/vm/benchmark_test.cc (right): https://codereview.chromium.org/2620413002/diff/1/runtime/vm/benchmark_test.cc#newcode101 runtime/vm/benchmark_test.cc:101: isolate_ = Dart_CreateIsolate(NULL, NULL, buffer, NULL, isolate_data, &err); On ...
3 years, 11 months ago (2017-01-11 19:11:08 UTC) #4
rmacnak
3 years, 11 months ago (2017-01-11 19:12:46 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
cbf3eaeb9043c335b5d16e2a7177994629ad9b1a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698