Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: runtime/vm/timeline_test.cc

Issue 2620413002: Fix various memory leaks in unit tests detected by a new version of ASAN. (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/snapshot_test.cc ('k') | runtime/vm/unit_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/timeline_test.cc
diff --git a/runtime/vm/timeline_test.cc b/runtime/vm/timeline_test.cc
index 2266898c9319981fe93c023ac4ecb0ccae2d65d8..aa2972facc19f498540fcce898fb71e4220b9816 100644
--- a/runtime/vm/timeline_test.cc
+++ b/runtime/vm/timeline_test.cc
@@ -91,7 +91,7 @@ class TimelineTestHelper : public AllStatic {
event->Complete();
}
- static void Clear(TimelineEventEndlessRecorder* recorder) {
+ static void Clear(TimelineEventRecorder* recorder) {
ASSERT(recorder != NULL);
recorder->Clear();
}
@@ -343,6 +343,8 @@ TEST_CASE(TimelineEventCallbackRecorderBasic) {
EXPECT_EQ(0, recorder->CountFor(TimelineEvent::kAsyncEnd));
event->Complete();
EXPECT_EQ(1, recorder->CountFor(TimelineEvent::kAsyncEnd));
+
+ delete recorder;
}
@@ -466,6 +468,9 @@ TEST_CASE(TimelineAnalysis_ThreadBlockCount) {
EXPECT(LabelMatch(it.Next(), "F"));
EXPECT(!it.HasNext());
}
+
+ TimelineTestHelper::Clear(recorder);
+ delete recorder;
}
@@ -502,6 +507,9 @@ TEST_CASE(TimelineRingRecorderJSONOrder) {
const char* alpha = strstr(js.ToCString(), "Alpha");
const char* beta = strstr(js.ToCString(), "Beta");
EXPECT(alpha < beta);
+
+ TimelineTestHelper::Clear(recorder);
+ delete recorder;
}
@@ -674,6 +682,8 @@ TEST_CASE(TimelinePauses_Basic) {
EXPECT_EQ(8, pauses.MaxExclusiveTime("a"));
}
TimelineTestHelper::Clear(recorder);
+
+ delete recorder;
}
@@ -884,6 +894,8 @@ TEST_CASE(TimelinePauses_BeginEnd) {
EXPECT(pauses.has_error());
}
TimelineTestHelper::Clear(recorder);
+
+ delete recorder;
}
#endif // !PRODUCT
« no previous file with comments | « runtime/vm/snapshot_test.cc ('k') | runtime/vm/unit_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698