Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2620383008: Updated independent-inheritance-fast-path.html to test all keywords. (Closed)

Created:
3 years, 11 months ago by napper
Modified:
3 years, 11 months ago
Reviewers:
sashab
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updated independent-inheritance-fast-path.html to test all keywords. Updated independent-inheritance-fast-path.html to test all keywords instead of just testing a single keyword. Updated the independent properties table to include all keywords for the independent properties. BUG=628043 Review-Url: https://codereview.chromium.org/2620383008 Cr-Commit-Position: refs/heads/master@{#443482} Committed: https://chromium.googlesource.com/chromium/src/+/b3ed3fda96b01e3447617f65c660c2eb6eeabdab

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added TODO to generate properties table from CSSProperties.in. #

Total comments: 1

Patch Set 3 : Change to comment describing elements in properties table. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -51 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html View 1 2 1 chunk +60 lines, -51 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
napper
Sasha, WDYT? Do we want to do this?
3 years, 11 months ago (2017-01-13 00:08:01 UTC) #3
sashab
Yes. 1 step better would be to generate this test from CSSProperties.in somehow. Maybe add ...
3 years, 11 months ago (2017-01-13 01:00:30 UTC) #5
napper
On 2017/01/13 at 01:00:30, sashab wrote: > Yes. 1 step better would be to generate ...
3 years, 11 months ago (2017-01-13 02:02:21 UTC) #8
sashab
Thanks; lgtm with comment change https://codereview.chromium.org/2620383008/diff/20001/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html File third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html (right): https://codereview.chromium.org/2620383008/diff/20001/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html#newcode15 third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html:15: // Property name, Value ...
3 years, 11 months ago (2017-01-13 02:03:37 UTC) #9
napper
On 2017/01/13 at 02:03:37, sashab wrote: > Thanks; lgtm with comment change > > https://codereview.chromium.org/2620383008/diff/20001/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html ...
3 years, 11 months ago (2017-01-13 02:08:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620383008/10002
3 years, 11 months ago (2017-01-13 02:08:38 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 03:54:58 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:10002) as
https://chromium.googlesource.com/chromium/src/+/b3ed3fda96b01e3447617f65c660...

Powered by Google App Engine
This is Rietveld 408576698