Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2620383004: Fix graphics layer backing and offset for composited selection handles. (Closed)

Created:
3 years, 11 months ago by chrishtr
Modified:
3 years, 11 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix graphics layer backing and offset for composited selection handles. This CL: 1. Moves the code out of LayoutObject. 2. Forces the GraphicsLayer to be m_graphicsLayer and not m_scrollingContentsLayer. TEST=manual testing BUG=679674 Review-Url: https://codereview.chromium.org/2620383004 Cr-Commit-Position: refs/heads/master@{#443107} Committed: https://chromium.googlesource.com/chromium/src/+/8e036fa110c1aa1f40aa536f3a2d14f1d78b6c30

Patch Set 1 #

Patch Set 2 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -46 lines) Patch
M third_party/WebKit/Source/core/editing/RenderedPosition.h View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/RenderedPosition.cpp View 1 3 chunks +43 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
chrishtr
3 years, 11 months ago (2017-01-11 23:57:46 UTC) #6
Xianzhu
lgtm. Please add an automatic test as a follow-up.
3 years, 11 months ago (2017-01-12 00:07:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620383004/20001
3 years, 11 months ago (2017-01-12 00:17:23 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 01:26:55 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8e036fa110c1aa1f40aa536f3a2d...

Powered by Google App Engine
This is Rietveld 408576698