Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1579)

Issue 2620383002: [NoStatePrefetch] Fix the PrefetchAge histogram to match histograms.xml (Closed)

Created:
3 years, 11 months ago by droger
Modified:
3 years, 11 months ago
Reviewers:
Benoit L, mattcary
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NoStatePrefetch] Fix the PrefetchAge histogram to match histograms.xml The code was using "Prerender.PrefetchAge" instead of "PrefetchAge", reporting wrong names (e.g. "Prerender.omnibox_Prerender.PrefetchAge" instead of "Prerender.omnibox_PrefetchAge"). Review-Url: https://codereview.chromium.org/2620383002 Cr-Commit-Position: refs/heads/master@{#442944} Committed: https://chromium.googlesource.com/chromium/src/+/3bbebdae9535ea4a21d85e5571a02c6a6fd36383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/prerender/prerender_histograms.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
droger
3 years, 11 months ago (2017-01-11 16:43:54 UTC) #4
mattcary
lgtm
3 years, 11 months ago (2017-01-11 16:49:18 UTC) #6
droger
+lizeb for the committer bit. Please send to CQ if it looks good.
3 years, 11 months ago (2017-01-11 17:00:10 UTC) #8
Benoit L
On 2017/01/11 17:00:10, droger wrote: > +lizeb for the committer bit. > > Please send ...
3 years, 11 months ago (2017-01-11 17:10:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620383002/20001
3 years, 11 months ago (2017-01-11 17:11:21 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 17:27:21 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3bbebdae9535ea4a21d85e5571a0...

Powered by Google App Engine
This is Rietveld 408576698