Reset pending request type on network error

Reset pending request type on network error

BUG=629305
Review-Url: https://codereview.chromium.org/2620373003
Cr-Commit-Position: refs/heads/master@{#443288}
Committed: https://chromium.googlesource.com/chromium/src/+/2bbd7cf1b775e07dc16f68a18386359cfc692c23

[rkjnsn, 2017-01-11 23:35:52]

rkjnsn@chromium.org changed reviewers:
+ msarda@chromium.org

[rkjnsn, 2017-01-11 23:35:52]

Please review the following changes.

GaiaOAuthClient sets the request type to NO_PENDING_REQUEST when a request is
successfully completed, but was not when the max 5xx retries were exceeded. As a
result, attempting to make another request with the same GaiaOAuthClient in that
case resulted in an assertion failure.

Thanks.

[rkjnsn, 2017-01-11 23:37:03]

Description was changed from

==========
Reset pending request on nework error

BUG=629305
==========

to

==========
Reset pending request type on nework error

BUG=629305
==========

[rkjnsn, 2017-01-11 23:37:26]

Description was changed from

==========
Reset pending request type on nework error

BUG=629305
==========

to

==========
Reset pending request type on network error

BUG=629305
==========

[msarda, 2017-01-12 14:30:37]

msarda@chromium.org changed reviewers:
+ rogerta@chromium.org

[msarda, 2017-01-12 14:30:37]

This patch L G T M, however I do not know if gaia_oauth_client.cc should be
reused for subsequent requests or if the client is supposed to create a new
instance.

Roger: May I ask you to also take a look?

[Roger Tawa OOO till Jul 10th, 2017-01-12 15:46:24]

lgtm

Yes, this class is designed to be reused, but have only one outstanding request
at a time.  There are asserts that check for this (which was his here).

[rkjnsn, 2017-01-12 15:48:32]

The CQ bit was checked by rkjnsn@chromium.org

[commit-bot: I haz the power, 2017-01-12 15:49:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 16:43:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 16:43:40]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rkjnsn, 2017-01-12 16:59:47]

The CQ bit was checked by rkjnsn@chromium.org

[commit-bot: I haz the power, 2017-01-12 17:00:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 17:59:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484240387853460, "parent_rev":
"3dcbdfb6ef790697a538ef3f0ab909e44af8ee5d", "commit_rev":
"2bbd7cf1b775e07dc16f68a18386359cfc692c23"}

[commit-bot: I haz the power, 2017-01-12 18:00:30]

Description was changed from

==========
Reset pending request type on network error

BUG=629305
==========

to

==========
Reset pending request type on network error

BUG=629305

Review-Url: https://codereview.chromium.org/2620373003
Cr-Commit-Position: refs/heads/master@{#443288}
Committed:
https://chromium.googlesource.com/chromium/src/+/2bbd7cf1b775e07dc16f68a18386...
==========

[commit-bot: I haz the power, 2017-01-12 18:00:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2bbd7cf1b775e07dc16f68a18386...