Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2620373003: Reset pending request type on network error (Closed)

Created:
3 years, 11 months ago by rkjnsn
Modified:
3 years, 11 months ago
CC:
chromium-reviews, Jamie
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset pending request type on network error BUG=629305 Review-Url: https://codereview.chromium.org/2620373003 Cr-Commit-Position: refs/heads/master@{#443288} Committed: https://chromium.googlesource.com/chromium/src/+/2bbd7cf1b775e07dc16f68a18386359cfc692c23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M google_apis/gaia/gaia_oauth_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client_unittest.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
rkjnsn
Please review the following changes. GaiaOAuthClient sets the request type to NO_PENDING_REQUEST when a request ...
3 years, 11 months ago (2017-01-11 23:35:52 UTC) #2
msarda
This patch L G T M, however I do not know if gaia_oauth_client.cc should be ...
3 years, 11 months ago (2017-01-12 14:30:37 UTC) #6
Roger Tawa OOO till Jul 10th
lgtm Yes, this class is designed to be reused, but have only one outstanding request ...
3 years, 11 months ago (2017-01-12 15:46:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620373003/1
3 years, 11 months ago (2017-01-12 15:49:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/367755)
3 years, 11 months ago (2017-01-12 16:43:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620373003/1
3 years, 11 months ago (2017-01-12 17:00:05 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 18:00:31 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2bbd7cf1b775e07dc16f68a18386...

Powered by Google App Engine
This is Rietveld 408576698