Implement Instance instances correctly; fix a few error cases

Implement Instance instances correctly; fix a few error cases

R=titzer@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2620263003
Cr-Commit-Position: refs/heads/master@{#42288}
Committed: https://chromium.googlesource.com/v8/v8/+/022635bf0ddb22f26654621a86d4c81430114403

[titzer, 2017-01-11 15:54:07]

lgtm

[rossberg, 2017-01-11 15:58:33]

The CQ bit was checked by rossberg@chromium.org

[commit-bot: I haz the power, 2017-01-11 15:58:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 16:00:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 16:00:10]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/18992)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/18900)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/32090)

[rossberg, 2017-01-11 16:31:58]

The CQ bit was checked by rossberg@chromium.org

[rossberg, 2017-01-11 16:31:58]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2620263003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-11 16:32:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 16:47:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 16:47:11]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[rossberg, 2017-01-12 15:12:10]

PTAL. Had to fix the WasmJs install logic, because we actually create instance
objects even when the API is not exposed. Simplified it on the way.

[titzer, 2017-01-12 15:19:01]

LGTM. I like the simplification.

https://codereview.chromium.org/2620263003/diff/40001/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (right):

https://codereview.chromium.org/2620263003/diff/40001/src/wasm/wasm-js.cc#new...
src/wasm/wasm-js.cc:734: // TODO(titzer): Move this to bootstrapper.cc??
I think you can drop this TODO now.

[rossberg, 2017-01-12 15:21:02]

https://codereview.chromium.org/2620263003/diff/40001/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (right):

https://codereview.chromium.org/2620263003/diff/40001/src/wasm/wasm-js.cc#new...
src/wasm/wasm-js.cc:734: // TODO(titzer): Move this to bootstrapper.cc??
On 2017/01/12 15:19:01, titzer wrote:
> I think you can drop this TODO now.

Done.

[rossberg, 2017-01-12 15:21:09]

The CQ bit was checked by rossberg@chromium.org

[rossberg, 2017-01-12 15:21:09]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2620263003/#ps60001
(title: "Remove obsolete TODO")

[commit-bot: I haz the power, 2017-01-12 15:21:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 15:31:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 15:31:43]

Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[rossberg, 2017-01-12 18:45:06]

The CQ bit was checked by rossberg@chromium.org

[rossberg, 2017-01-12 18:45:06]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2620263003/#ps80001
(title: "Tenure instance objects")

[commit-bot: I haz the power, 2017-01-12 18:45:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 18:46:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 18:46:46]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/19028)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/32207)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/20734)

[rossberg, 2017-01-12 19:05:19]

The CQ bit was checked by rossberg@chromium.org

[rossberg, 2017-01-12 19:05:20]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2620263003/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-12 19:05:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 19:21:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 19:21:37]

Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)

[rossberg, 2017-01-12 19:58:16]

The CQ bit was checked by rossberg@chromium.org

[rossberg, 2017-01-12 19:58:17]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2620263003/#ps120001
(title: "Export flag")

[commit-bot: I haz the power, 2017-01-12 19:58:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 20:32:28]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1484251096610250,
"parent_rev": "1d32a3989bc474745eeb618ebf094634f4efbb36", "commit_rev":
"022635bf0ddb22f26654621a86d4c81430114403"}

[commit-bot: I haz the power, 2017-01-12 20:32:32]

Description was changed from

==========
Implement Instance instances correctly; fix a few error cases

R=titzer@chromium.org
BUG=
==========

to

==========
Implement Instance instances correctly; fix a few error cases

R=titzer@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2620263003
Cr-Commit-Position: refs/heads/master@{#42288}
Committed:
https://chromium.googlesource.com/v8/v8/+/022635bf0ddb22f26654621a86d4c814301...
==========

[commit-bot: I haz the power, 2017-01-12 20:32:33]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/022635bf0ddb22f26654621a86d4c814301...