Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issue 2620263002: CSS: Scale support for none (Closed)

Created:
3 years, 11 months ago by divyanshi
Modified:
3 years, 11 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS: Scale support for none The initial value for scale is none not 1 https://drafts.csswg.org/css-transforms-2/#individual-transforms BUG=679873 Review-Url: https://codereview.chromium.org/2620263002 Cr-Commit-Position: refs/heads/master@{#443051} Committed: https://chromium.googlesource.com/chromium/src/+/82f137db47aaedf2f741cd2615c735a1980dc7ce

Patch Set 1 #

Total comments: 1

Messages

Total messages: 17 (10 generated)
divyanshi
3 years, 11 months ago (2017-01-11 04:26:50 UTC) #2
Eric Willigers
lgtm We will also need to update animation, but that can be in a later ...
3 years, 11 months ago (2017-01-11 04:28:18 UTC) #5
Eric Willigers
3 years, 11 months ago (2017-01-11 04:40:47 UTC) #7
sashab
lgtm
3 years, 11 months ago (2017-01-11 22:55:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620263002/1
3 years, 11 months ago (2017-01-11 22:57:37 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/82f137db47aaedf2f741cd2615c735a1980dc7ce
3 years, 11 months ago (2017-01-11 23:19:56 UTC) #15
Timothy Loh
3 years, 11 months ago (2017-01-12 00:07:18 UTC) #17
Message was sent while issue was closed.
https://codereview.chromium.org/2620263002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/2620263002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:727: return
consumeIdent(range);
Is this tested?

Powered by Google App Engine
This is Rietveld 408576698