Update Page Info on iOS to an interim Material Design state.

Update Page Info on iOS to an interim Material Design state.

This brings it mostly in sync with other platforms by replacing two sections (identity info and connection info) with a single section containing a security summary and a sentence with details about what the security state means.

This CL also:
- Drops logic to show error strings related to and SHA-1 deprecation, since we don't detail this on desktop and some of these states can't even be detected on WKWebView anymore.
- Preserves the layout code for multiple sections, even if we only show a single one now.
- Preserves certificate information for devs/power users, since there is no other way to get the info until we have a certificate viewer on iOS (crbug.com/502470).

BUG=680784, 656843, 640478
TEST=Visit the following sites and check against the screenshots at crbug.com/680784#c1 :
- expired.badssl.com (on iPhone)
- mixed.badssl.com (on iPhone)
- http-login.badssl.com (on iPhone)
- www.google.com (on iPhone)
- http.badssl.com (on iPad)

Review-Url: https://codereview.chromium.org/2620243005
Cr-Commit-Position: refs/heads/master@{#444919}
Committed: https://chromium.googlesource.com/chromium/src/+/a6dd3781121d6a697d9d525e9d965f38c72b8df0

[lgarron, 2017-01-13 00:03:51]

Patchset #1 (id:1) has been deleted

[lgarron, 2017-01-13 00:03:57]

Description was changed from

==========
Update Page Info on iOS to an interim Material Design state.

This brings it mostly in sync with other platforms, while:
- Preserving the layout code.
- Preserving certificate information for devs/power users (since there is no
other way to get the info).

BUG=680784, 656843, 640478
TEST=Visit the following sites and check against the screenshots at
crbug.com/680784#c1 :
- expired.badssl.com (on iPhone)
- mixed.badssl.com (on iPhone)
- http-login.badssl.com (on iPhone)
- www.google.com (on iPhone)
- http.badssl.com (on iPad)

iOS: Add the Page Info password/credit card string for HTTP pages.

This also updates the "What do these mean?" link to "Learn more" to match
Desktop material design.

Move Page Info security summary and detail strings into `pageinfo_strings.grdp`.

This allows them to be used on iOS.

This CL also makes estark@ and lgarron@ owners of page info strings.

BUG=679976

patch from issue 2620123003 at patchset 20001
(http://crrev.com/2620123003#ps20001)
==========

to

==========
Update Page Info on iOS to an interim Material Design state.

This brings it mostly in sync with other platforms, while:
- Preserving the layout code.
- Preserving certificate information for devs/power users (since there is no
other way to get the info).

BUG=680784, 656843, 640478
TEST=Visit the following sites and check against the screenshots at
crbug.com/680784#c1 :
- expired.badssl.com (on iPhone)
- mixed.badssl.com (on iPhone)
- http-login.badssl.com (on iPhone)
- www.google.com (on iPhone)
- http.badssl.com (on iPad)

iOS: Add the Page Info password/credit card string for HTTP pages.

This also updates the "What do these mean?" link to "Learn more" to match
Desktop material design.

Move Page Info security summary and detail strings into `pageinfo_strings.grdp`.

This allows them to be used on iOS.

This CL also makes estark@ and lgarron@ owners of page info strings.

BUG=679976
==========

[lgarron, 2017-01-13 00:04:04]

Description was changed from

==========
Update Page Info on iOS to an interim Material Design state.

This brings it mostly in sync with other platforms, while:
- Preserving the layout code.
- Preserving certificate information for devs/power users (since there is no
other way to get the info).

BUG=680784, 656843, 640478
TEST=Visit the following sites and check against the screenshots at
crbug.com/680784#c1 :
- expired.badssl.com (on iPhone)
- mixed.badssl.com (on iPhone)
- http-login.badssl.com (on iPhone)
- www.google.com (on iPhone)
- http.badssl.com (on iPad)

iOS: Add the Page Info password/credit card string for HTTP pages.

This also updates the "What do these mean?" link to "Learn more" to match
Desktop material design.

Move Page Info security summary and detail strings into `pageinfo_strings.grdp`.

This allows them to be used on iOS.

This CL also makes estark@ and lgarron@ owners of page info strings.

BUG=679976
==========

to

==========
Update Page Info on iOS to an interim Material Design state.

This brings it mostly in sync with other platforms, while:
- Preserving the layout code.
- Preserving certificate information for devs/power users (since there is no
other way to get the info).

BUG=680784, 656843, 640478
TEST=Visit the following sites and check against the screenshots at
crbug.com/680784#c1 :
- expired.badssl.com (on iPhone)
- mixed.badssl.com (on iPhone)
- http-login.badssl.com (on iPhone)
- www.google.com (on iPhone)
- http.badssl.com (on iPad)
==========

[lgarron, 2017-01-13 00:07:53]

lgarron@chromium.org changed reviewers:
+ rohitrao@chromium.org

[lgarron, 2017-01-13 00:07:54]

rohitrao@, could you review?

I've shredded a bunch of what I believe to be dead code, and focused on making
the main cases (see TEST=) more straightforward to understand.

This is not intended to be the final state (I'm refactoring Page Info on all
platforms this quarter, and planning to unify string calculations), but it is
meant to tide us over for a release or two.

[rohitrao (ping after 24h), 2017-01-13 00:14:08]

> This is not intended to be the final state (I'm refactoring Page Info on all
> platforms this quarter, and planning to unify string calculations), but it is
> meant to tide us over for a release or two.

Do you have any plans to get iOS off of this forked PageInfoModel code
completely and onto something shared, like WebsiteSettings?  This has been on my
list for a long time, but I haven't found time to plan out how to componentize
the WebsiteSettings code.  I really don't want to stay on PageInfoModel long
term.

[lgarron, 2017-01-13 00:39:28]

On 2017/01/13 at 00:14:08, rohitrao wrote:
> > This is not intended to be the final state (I'm refactoring Page Info on all
> > platforms this quarter, and planning to unify string calculations), but it
is
> > meant to tide us over for a release or two.
> 
> Do you have any plans to get iOS off of this forked PageInfoModel code
completely and onto something shared, like WebsiteSettings?  This has been on my
list for a long time, but I haven't found time to plan out how to componentize
the WebsiteSettings code.  I really don't want to stay on PageInfoModel long
term.

Yes, the goal is to put all calculations in the security_state component, so
that PageInfoModel is either gone, or a thin wrapper.

https://bugs.chromium.org/p/chromium/issues/detail?id=571533
https://bugs.chromium.org/p/chromium/issues/detail?id=647553

[lgarron, 2017-01-18 00:06:47]

rohitrao@: I know this is a large change to the PageInfoModel constructor; but
do you think you'll have have time to review it for M57? (Or is there a big
overall fix I would need before landing, no matter what?)

[rohitrao (ping after 24h), 2017-01-19 01:26:08]

lgtm

Is it possible to update the CL description with a short summary of what
specifically changed?  It looks like some sections of code were reordered and
others were removed completely, but it was hard to tell what the difference in
functionality is.

https://codereview.chromium.org/2620243005/diff/40001/ios/chrome/browser/ui/o...
File ios/chrome/browser/ui/omnibox/page_info_model.cc (right):

https://codereview.chromium.org/2620243005/diff/40001/ios/chrome/browser/ui/o...
ios/chrome/browser/ui/omnibox/page_info_model.cc:62: hostname.clear();
What does clear()ing an empty string do?

https://codereview.chromium.org/2620243005/diff/40001/ios/chrome/browser/ui/o...
ios/chrome/browser/ui/omnibox/page_info_model.cc:69: // Summary and detais.
Typo: details.

https://codereview.chromium.org/2620243005/diff/40001/ios/chrome/browser/ui/o...
ios/chrome/browser/ui/omnibox/page_info_model.cc:76: } else {
There are a lot of nested if/else statements, and it might be helpful if each
one had a short comment explaining what case it covered.

[lgarron, 2017-01-19 21:21:18]

Description was changed from

==========
Update Page Info on iOS to an interim Material Design state.

This brings it mostly in sync with other platforms, while:
- Preserving the layout code.
- Preserving certificate information for devs/power users (since there is no
other way to get the info).

BUG=680784, 656843, 640478
TEST=Visit the following sites and check against the screenshots at
crbug.com/680784#c1 :
- expired.badssl.com (on iPhone)
- mixed.badssl.com (on iPhone)
- http-login.badssl.com (on iPhone)
- www.google.com (on iPhone)
- http.badssl.com (on iPad)
==========

to

==========
Update Page Info on iOS to an interim Material Design state.

This brings it mostly in sync with other platforms by replacing two sections
(identity info and connection info) with a single section containing a security
summary and a sentence with details about what the security state means.

This CL also:
- Preserves the layout code for multiple sections, even if we only show a single
one now.
- Preserves certificate information for devs/power users, since there is no
other way to get the info until we have a certificate viewer on iOS
(crbug.com/502470).

BUG=680784, 656843, 640478
TEST=Visit the following sites and check against the screenshots at
crbug.com/680784#c1 :
- expired.badssl.com (on iPhone)
- mixed.badssl.com (on iPhone)
- http-login.badssl.com (on iPhone)
- www.google.com (on iPhone)
- http.badssl.com (on iPad)
==========

[lgarron, 2017-01-19 21:23:12]

Description was changed from

==========
Update Page Info on iOS to an interim Material Design state.

This brings it mostly in sync with other platforms by replacing two sections
(identity info and connection info) with a single section containing a security
summary and a sentence with details about what the security state means.

This CL also:
- Preserves the layout code for multiple sections, even if we only show a single
one now.
- Preserves certificate information for devs/power users, since there is no
other way to get the info until we have a certificate viewer on iOS
(crbug.com/502470).

BUG=680784, 656843, 640478
TEST=Visit the following sites and check against the screenshots at
crbug.com/680784#c1 :
- expired.badssl.com (on iPhone)
- mixed.badssl.com (on iPhone)
- http-login.badssl.com (on iPhone)
- www.google.com (on iPhone)
- http.badssl.com (on iPad)
==========

to

==========
Update Page Info on iOS to an interim Material Design state.

This brings it mostly in sync with other platforms by replacing two sections
(identity info and connection info) with a single section containing a security
summary and a sentence with details about what the security state means.

This CL also:
- Drops logic to show error strings related to and SHA-1 deprecation, since we
don't detail this on desktop and some of these states can't even be detected on
WKWebView anymore.
- Preserves the layout code for multiple sections, even if we only show a single
one now.
- Preserves certificate information for devs/power users, since there is no
other way to get the info until we have a certificate viewer on iOS
(crbug.com/502470).

BUG=680784, 656843, 640478
TEST=Visit the following sites and check against the screenshots at
crbug.com/680784#c1 :
- expired.badssl.com (on iPhone)
- mixed.badssl.com (on iPhone)
- http-login.badssl.com (on iPhone)
- www.google.com (on iPhone)
- http.badssl.com (on iPad)
==========

[lgarron, 2017-01-19 21:26:20]

https://codereview.chromium.org/2620243005/diff/40001/ios/chrome/browser/ui/o...
File ios/chrome/browser/ui/omnibox/page_info_model.cc (right):

https://codereview.chromium.org/2620243005/diff/40001/ios/chrome/browser/ui/o...
ios/chrome/browser/ui/omnibox/page_info_model.cc:62: hostname.clear();
On 2017/01/19 at 01:26:08, rohitrao wrote:
> What does clear()ing an empty string do?

Ah, uh, nothing? :-P
This is vestigial now, so I've removed it.

https://codereview.chromium.org/2620243005/diff/40001/ios/chrome/browser/ui/o...
ios/chrome/browser/ui/omnibox/page_info_model.cc:69: // Summary and detais.
On 2017/01/19 at 01:26:08, rohitrao wrote:
> Typo: details.

Fixed.

https://codereview.chromium.org/2620243005/diff/40001/ios/chrome/browser/ui/o...
ios/chrome/browser/ui/omnibox/page_info_model.cc:76: } else {
On 2017/01/19 at 01:26:08, rohitrao wrote:
> There are a lot of nested if/else statements, and it might be helpful if each
one had a short comment explaining what case it covered.

Added.

[lgarron, 2017-01-19 21:26:21]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2017-01-19 21:26:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2620243005/#ps60001
(title: "Update Page Info on iOS to an interim Material Design state.")

[commit-bot: I haz the power, 2017-01-19 21:26:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 21:29:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 21:29:02]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[lgarron, 2017-01-19 21:29:59]

Patchset #3 (id:60001) has been deleted

[lgarron, 2017-01-19 21:30:37]

Patchset #3 (id:80001) has been deleted

[lgarron, 2017-01-19 21:32:00]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2017-01-19 21:32:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2620243005/#ps100001
(title: "Update Page Info on iOS to an interim Material Design state.")

[commit-bot: I haz the power, 2017-01-19 21:32:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 21:34:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 21:34:50]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[lgarron, 2017-01-19 22:49:57]

Patchset #3 (id:100001) has been deleted

[lgarron, 2017-01-19 22:50:02]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2017-01-19 22:50:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2620243005/#ps120001
(title: "Update Page Info on iOS to an interim Material Design state.")

[commit-bot: I haz the power, 2017-01-19 22:50:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 22:54:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 22:54:18]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lgarron, 2017-01-19 23:01:05]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2017-01-19 23:01:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2620243005/#ps140001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-19 23:01:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 01:24:02]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1484866865587570,
"parent_rev": "274da537e7c6531cf15a4145c408607df06e6b8f", "commit_rev":
"a6dd3781121d6a697d9d525e9d965f38c72b8df0"}

[commit-bot: I haz the power, 2017-01-20 01:24:30]

Description was changed from

==========
Update Page Info on iOS to an interim Material Design state.

This brings it mostly in sync with other platforms by replacing two sections
(identity info and connection info) with a single section containing a security
summary and a sentence with details about what the security state means.

This CL also:
- Drops logic to show error strings related to and SHA-1 deprecation, since we
don't detail this on desktop and some of these states can't even be detected on
WKWebView anymore.
- Preserves the layout code for multiple sections, even if we only show a single
one now.
- Preserves certificate information for devs/power users, since there is no
other way to get the info until we have a certificate viewer on iOS
(crbug.com/502470).

BUG=680784, 656843, 640478
TEST=Visit the following sites and check against the screenshots at
crbug.com/680784#c1 :
- expired.badssl.com (on iPhone)
- mixed.badssl.com (on iPhone)
- http-login.badssl.com (on iPhone)
- www.google.com (on iPhone)
- http.badssl.com (on iPad)
==========

to

==========
Update Page Info on iOS to an interim Material Design state.

This brings it mostly in sync with other platforms by replacing two sections
(identity info and connection info) with a single section containing a security
summary and a sentence with details about what the security state means.

This CL also:
- Drops logic to show error strings related to and SHA-1 deprecation, since we
don't detail this on desktop and some of these states can't even be detected on
WKWebView anymore.
- Preserves the layout code for multiple sections, even if we only show a single
one now.
- Preserves certificate information for devs/power users, since there is no
other way to get the info until we have a certificate viewer on iOS
(crbug.com/502470).

BUG=680784, 656843, 640478
TEST=Visit the following sites and check against the screenshots at
crbug.com/680784#c1 :
- expired.badssl.com (on iPhone)
- mixed.badssl.com (on iPhone)
- http-login.badssl.com (on iPhone)
- www.google.com (on iPhone)
- http.badssl.com (on iPad)

Review-Url: https://codereview.chromium.org/2620243005
Cr-Commit-Position: refs/heads/master@{#444919}
Committed:
https://chromium.googlesource.com/chromium/src/+/a6dd3781121d6a697d9d525e9d96...
==========

[commit-bot: I haz the power, 2017-01-20 01:24:32]

Committed patchset #4 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/a6dd3781121d6a697d9d525e9d96...