Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2620213004: Remove all blimp browsertests. (Closed)

Created:
3 years, 11 months ago by nyquist
Modified:
3 years, 11 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, vmpstr+watch_chromium.org, bgoldman+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all blimp browsertests. This CL removes all the BlimpBrowserTest tests, and related files. It also removes the test suite from the build bots, and a ThreadRestrictions friend-class from //base. BUG=677556 Review-Url: https://codereview.chromium.org/2620213004 Cr-Commit-Position: refs/heads/master@{#443306} Committed: https://chromium.googlesource.com/chromium/src/+/080b78c46001c096c9029d24e781e0b78aface5f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1445 lines) Patch
M base/threading/thread_restrictions.h View 2 chunks +0 lines, -4 lines 0 comments Download
M blimp/BUILD.gn View 3 chunks +1 line, -14 lines 0 comments Download
M blimp/client/core/compositor/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/client/core/contents/BUILD.gn View 2 chunks +2 lines, -8 lines 0 comments Download
M blimp/client/core/context/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/client/core/geolocation/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M blimp/client/core/render_widget/BUILD.gn View 2 chunks +1 line, -5 lines 0 comments Download
M blimp/client/core/session/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M blimp/client/core/settings/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M blimp/client/core/switches/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M blimp/docs/test.md View 1 chunk +0 lines, -6 lines 0 comments Download
M blimp/engine/BUILD.gn View 1 chunk +0 lines, -62 lines 0 comments Download
D blimp/engine/browser_tests/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D blimp/engine/browser_tests/blimp_browser_test.h View 1 chunk +0 lines, -80 lines 0 comments Download
D blimp/engine/browser_tests/blimp_browser_test.cc View 1 chunk +0 lines, -136 lines 0 comments Download
D blimp/engine/browser_tests/blimp_client_session.h View 1 chunk +0 lines, -125 lines 0 comments Download
D blimp/engine/browser_tests/blimp_client_session.cc View 1 chunk +0 lines, -181 lines 0 comments Download
D blimp/engine/browser_tests/blimp_contents_view_readback_helper.h View 1 chunk +0 lines, -49 lines 0 comments Download
D blimp/engine/browser_tests/blimp_contents_view_readback_helper.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D blimp/engine/browser_tests/blimp_test_launcher.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D blimp/engine/browser_tests/input_browsertest.cc View 1 chunk +0 lines, -181 lines 0 comments Download
D blimp/engine/browser_tests/integration_test.cc View 1 chunk +0 lines, -164 lines 0 comments Download
D blimp/engine/browser_tests/navigation_browsertest.cc View 1 chunk +0 lines, -189 lines 0 comments Download
D blimp/engine/browser_tests/test_client_session.h View 1 chunk +0 lines, -25 lines 0 comments Download
D blimp/engine/browser_tests/test_client_session.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D blimp/engine/browser_tests/waitable_content_pump.h View 1 chunk +0 lines, -43 lines 0 comments Download
D blimp/engine/browser_tests/waitable_content_pump.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 chunk +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 chunk +0 lines, -6 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
nyquist
dtrainor: PTAL everything dpranke: PTAL //testing jam: PTAL //base/threading/thread_restrictions.h
3 years, 11 months ago (2017-01-12 17:27:38 UTC) #5
jam
lgtm
3 years, 11 months ago (2017-01-12 18:22:30 UTC) #6
Dirk Pranke
lgtm
3 years, 11 months ago (2017-01-12 18:32:47 UTC) #7
David Trainor- moved to gerrit
lgtm
3 years, 11 months ago (2017-01-12 18:43:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620213004/1
3 years, 11 months ago (2017-01-12 18:44:47 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 18:52:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/080b78c46001c096c9029d24e781...

Powered by Google App Engine
This is Rietveld 408576698