Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2620213002: Revert of A simple, practically zero cost fallback crash handler for Crashpad handler process. (Closed)

Created:
3 years, 11 months ago by dschuyler
Modified:
3 years, 11 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, sadrul, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of A simple, practically zero cost fallback crash handler for Crashpad handler process. (patchset #14 id:260001 of https://codereview.chromium.org/2596463002/ ) Reason for revert: Sorry, it looks like the new patch also has a build failure. See crbug 679920. (I'm not 100% sure, this is my best guess, apologies if it turns out incorrect). Original issue's description: > A simple, practically zero cost fallback crash handler for Crashpad handler process. > > This implements a fallback crash handler launcher. The launcher will be instantiated in the Crashpad handler process, where it pre-computes a command line to be launched on crash. This will be triggered off the UEF, under some form of single-instance locking. > > BUG=678959 > > Review-Url: https://codereview.chromium.org/2596463002 > Cr-Original-Commit-Position: refs/heads/master@{#442596} > Committed: https://chromium.googlesource.com/chromium/src/+/d4e43bb5146c7a59123ff5f3b6e853d8e8c29130 > Review-Url: https://codereview.chromium.org/2596463002 > Cr-Commit-Position: refs/heads/master@{#442698} > Committed: https://chromium.googlesource.com/chromium/src/+/f87fdaa12b09ff286d873e7a3ea459507d7adb83 TBR=scottmg@chromium.org,siggi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=678959 Review-Url: https://codereview.chromium.org/2620213002 Cr-Commit-Position: refs/heads/master@{#442742} Committed: https://chromium.googlesource.com/chromium/src/+/a37e7afabb6be7d7a12667fb29d9f74556589abf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -360 lines) Patch
M components/crash/content/app/BUILD.gn View 2 chunks +3 lines, -10 lines 0 comments Download
D components/crash/content/app/fallback_crash_handler_launcher_win.h View 1 chunk +0 lines, -68 lines 0 comments Download
D components/crash/content/app/fallback_crash_handler_launcher_win.cc View 1 chunk +0 lines, -131 lines 0 comments Download
D components/crash/content/app/fallback_crash_handler_launcher_win_unittest.cc View 1 chunk +0 lines, -151 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dschuyler
Created Revert of A simple, practically zero cost fallback crash handler for Crashpad handler process.
3 years, 11 months ago (2017-01-11 00:27:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620213002/1
3 years, 11 months ago (2017-01-11 00:28:34 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 00:29:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a37e7afabb6be7d7a12667fb29d9...

Powered by Google App Engine
This is Rietveld 408576698