Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2620203005: [wasm] Implement the WebAssembly.Module.imports function. (Closed)

Created:
3 years, 11 months ago by titzer
Modified:
3 years, 11 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Implement the WebAssembly.Module.imports function. R=rossberg@chromium.org BUG=v8:5813, chromium:575167 Review-Url: https://codereview.chromium.org/2620203005 Cr-Commit-Position: refs/heads/master@{#42231} Committed: https://chromium.googlesource.com/v8/v8/+/d5a0860e87b5f8d88432cf628f4bbc0cc922317f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -5 lines) Patch
M src/wasm/wasm-js.cc View 2 chunks +32 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +72 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/js-api.js View 3 chunks +12 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
titzer
3 years, 11 months ago (2017-01-11 11:56:42 UTC) #1
rossberg
lgtm
3 years, 11 months ago (2017-01-11 14:07:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620203005/1
3 years, 11 months ago (2017-01-11 14:16:19 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 14:17:58 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d5a0860e87b5f8d88432cf628f4bbc0cc92...

Powered by Google App Engine
This is Rietveld 408576698