Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2620193003: Remove obsolete unused file. (Closed)

Created:
3 years, 11 months ago by Torne
Modified:
3 years, 11 months ago
Reviewers:
Tobias Sargeant
CC:
chromium-reviews, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete unused file. WebView now generates NativeLibraries.java at runtime in the same way as all other Android APKs. Delete the unused pregenerated version. BUG= Review-Url: https://codereview.chromium.org/2620193003 Cr-Commit-Position: refs/heads/master@{#442933} Committed: https://chromium.googlesource.com/chromium/src/+/8a607b49cbcfbb114cd12dd80abc0997c5f3e379

Patch Set 1 #

Patch Set 2 : also remove from classpath lists #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
D android_webview/java/generated_src/org/chromium/base/library_loader/NativeLibraries.java View 1 chunk +0 lines, -32 lines 0 comments Download
M docs/chromoting_android_hacking.md View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/android/eclipse/.classpath View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Torne
Not sure how long ago we stopped needing this, but we generate this file at ...
3 years, 11 months ago (2017-01-11 16:38:32 UTC) #2
Tobias Sargeant
lgtm
3 years, 11 months ago (2017-01-11 16:44:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620193003/20001
3 years, 11 months ago (2017-01-11 16:51:25 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 17:03:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8a607b49cbcfbb114cd12dd80abc...

Powered by Google App Engine
This is Rietveld 408576698