Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2620153002: Fix front-end host creation upon navigation (Closed)

Created:
3 years, 11 months ago by caseq
Modified:
3 years, 11 months ago
Reviewers:
dgozman, Dan Beam, pfeldman
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix front-end host creation upon navigation - when navigating, add host bindings to the pending frame rather than old frame; - force renderer swap if front-end URL is invalid; - move front-end URL validation to DevToolsUIBindingds This also re-lands https://codereview.chromium.org/2607833002 BUG=662859, 678035 Review-Url: https://codereview.chromium.org/2620153002 Cr-Commit-Position: refs/heads/master@{#442781} Committed: https://chromium.googlesource.com/chromium/src/+/c2db881506f5709433a5bf6ed981b1bc0c860598

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rewritten to use new navigation signals #

Patch Set 3 : removed stray change #

Patch Set 4 : rebased on top of https://codereview.chromium.org/2607833002/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -279 lines) Patch
M chrome/browser/devtools/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.h View 1 2 3 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 2 3 12 chunks +167 lines, -16 lines 0 comments Download
A + chrome/browser/devtools/devtools_ui_bindings_unittest.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/devtools/url_constants.h View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/browser/devtools/url_constants.cc View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.h View 1 2 3 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 1 2 3 5 chunks +7 lines, -148 lines 0 comments Download
D chrome/browser/ui/webui/devtools_ui_unittest.cc View 1 2 3 1 chunk +0 lines, -102 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
caseq
This is relative to ToT now, but I'm going to revert https://codereview.chromium.org/2607833002 and rebase this ...
3 years, 11 months ago (2017-01-10 21:48:52 UTC) #2
pfeldman
https://codereview.chromium.org/2620153002/diff/1/chrome/browser/devtools/devtools_ui_bindings.cc File chrome/browser/devtools/devtools_ui_bindings.cc (right): https://codereview.chromium.org/2620153002/diff/1/chrome/browser/devtools/devtools_ui_bindings.cc#newcode557 chrome/browser/devtools/devtools_ui_bindings.cc:557: UpdateFrontendHost(web_contents_->GetVisibleURL()); I don't think you need this call - ...
3 years, 11 months ago (2017-01-10 22:31:51 UTC) #3
pfeldman
lgtm
3 years, 11 months ago (2017-01-10 22:32:32 UTC) #4
caseq
ptal
3 years, 11 months ago (2017-01-10 23:44:18 UTC) #5
pfeldman
still lgtm
3 years, 11 months ago (2017-01-10 23:46:18 UTC) #6
caseq
+dbeam for chrome/browser/ui/webui/OWNERS -- ptal, the change in chrome_web_ui_controller_factory.cc adds validation for chrome-devtools:// URLs.
3 years, 11 months ago (2017-01-10 23:53:49 UTC) #8
dgozman
lgtm
3 years, 11 months ago (2017-01-11 00:20:32 UTC) #9
Dan Beam
lgtm
3 years, 11 months ago (2017-01-11 00:39:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620153002/60001
3 years, 11 months ago (2017-01-11 01:48:08 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 03:40:07 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c2db881506f5709433a5bf6ed981...

Powered by Google App Engine
This is Rietveld 408576698