Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 2620093002: [DevTools] Support BreakReason.OOM (Closed)

Created:
3 years, 11 months ago by kozy
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Support BreakReason.OOM Show correct debugger paused message. BUG=chromium:675911 Review-Url: https://codereview.chromium.org/2620093002 Cr-Commit-Position: refs/heads/master@{#445943} Committed: https://chromium.googlesource.com/chromium/src/+/e1c22801b062c8638e1640290fdcf08923b380a9

Patch Set 1 #

Patch Set 2 : a #

Total comments: 2

Patch Set 3 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js View 1 2 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
kozy
Dmitry, please take a look. We maybe would like to notify users that heap limits ...
3 years, 11 months ago (2017-01-11 11:36:11 UTC) #3
dgozman
lgtm https://codereview.chromium.org/2620093002/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js File third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js (right): https://codereview.chromium.org/2620093002/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js#newcode55 third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js:55: messageWrapper = buildWrapper(Common.UIString('Paused before potential OOM')); ... out-of-memory ...
3 years, 11 months ago (2017-01-12 23:48:20 UTC) #4
kozy
all done! https://codereview.chromium.org/2620093002/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js File third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js (right): https://codereview.chromium.org/2620093002/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js#newcode55 third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js:55: messageWrapper = buildWrapper(Common.UIString('Paused before potential OOM')); On ...
3 years, 11 months ago (2017-01-25 02:52:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620093002/40001
3 years, 11 months ago (2017-01-25 02:53:03 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 04:34:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e1c22801b062c8638e1640290fdc...

Powered by Google App Engine
This is Rietveld 408576698