Shape Detection: Move mojom interface to //services

Shape Detection: Move mojom interface to //services

This CL moves Shape Detection mojo interfaces to //services, which exposes them
to public instead of just Blink. No new code added.

Blocking: https://codereview.chromium.org/2460723003/


TBR=haraken@chromium.org (mechanical move)
BUG=646083, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2620083002
Cr-Commit-Position: refs/heads/master@{#442991}
Committed: https://chromium.googlesource.com/chromium/src/+/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3

[xianglu, 2017-01-10 19:14:30]

Description was changed from

==========
Shape Detection: Move mojom interface to //services

BUG=
==========

to

==========
Shape Detection: Move mojom interface to //services

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xianglu, 2017-01-10 19:14:42]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 19:15:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2017-01-10 19:16:59]

The CQ bit was unchecked by xianglu@chromium.org

[xianglu, 2017-01-10 19:34:20]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 19:34:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2017-01-10 20:08:42]

Patchset #1 (id:1) has been deleted

[xianglu, 2017-01-10 20:10:22]

Patchset #2 (id:40001) has been deleted

[xianglu, 2017-01-10 20:18:52]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 20:19:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2017-01-10 20:22:34]

Description was changed from

==========
Shape Detection: Move mojom interface to //services

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Move mojom interface to //services

BUG=646083, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xianglu, 2017-01-10 20:26:09]

Description was changed from

==========
Shape Detection: Move mojom interface to //services

BUG=646083, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Move mojom interface to //services

This CL moves Shape Detection interfaces to //services. This exposes them to
public instead of just Blink.

BUG=646083, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xianglu, 2017-01-10 20:26:56]

Description was changed from

==========
Shape Detection: Move mojom interface to //services

This CL moves Shape Detection interfaces to //services. This exposes them to
public instead of just Blink.

BUG=646083, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Move mojom interface to //services

This CL moves Shape Detection interfaces to //services. This exposes them to
public instead of just Blink.

BUG=646083, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xianglu, 2017-01-10 20:39:16]

Patchset #1 (id:20001) has been deleted

[xianglu, 2017-01-10 20:40:03]

xianglu@chromium.org changed reviewers:
+ mcasas@chromium.org

[xianglu, 2017-01-10 20:40:04]

PTAL.

[xianglu, 2017-01-10 21:25:42]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 21:26:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2017-01-10 21:52:17]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 21:52:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2017-01-10 21:53:46]

Patchset #1 (id:60001) has been deleted

[xianglu, 2017-01-10 21:53:56]

Patchset #1 (id:80001) has been deleted

[mcasas, 2017-01-10 22:20:24]

On 2017/01/10 20:40:04, xianglu wrote:
> PTAL.

lgtm

please mention in the description that this moving
around of files is a predecessor for your other CL 
https://crrev.com/2528743002

[mcasas, 2017-01-10 22:20:32]

https://codereview.chromium.org/2620083002/diff/100001/chrome/browser/chrome_...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/2620083002/diff/100001/chrome/browser/chrome_...
chrome/browser/chrome_content_browser_client.cc:3011:
shape_detection::mojom::TextDetection>());
TextDetection registration is already in ToT. Wrong rebase?

[xianglu, 2017-01-10 22:31:45]

Description was changed from

==========
Shape Detection: Move mojom interface to //services

This CL moves Shape Detection interfaces to //services. This exposes them to
public instead of just Blink.

BUG=646083, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Move mojom interface to //services

This CL moves Shape Detection interfaces to //services. This exposes them to
public instead of just Blink.

blocking: https://codereview.chromium.org/2460723003/

BUG=646083, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xianglu, 2017-01-10 22:31:59]

Description was changed from

==========
Shape Detection: Move mojom interface to //services

This CL moves Shape Detection interfaces to //services. This exposes them to
public instead of just Blink.

blocking: https://codereview.chromium.org/2460723003/

BUG=646083, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Move mojom interface to //services

This CL moves Shape Detection interfaces to //services. This exposes them to
public instead of just Blink.

Blocking: https://codereview.chromium.org/2460723003/


BUG=646083, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xianglu, 2017-01-10 22:33:53]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 22:34:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2017-01-10 22:35:25]

Patchset #2 (id:120001) has been deleted

[commit-bot: I haz the power, 2017-01-10 22:36:56]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[xianglu, 2017-01-10 22:43:29]

xianglu@chromium.org changed reviewers:
+ avi@chromium.org, dtrainor@chromium.org, haraken@chromium.org,
rockot@chromium.org, tsepez@chromium.org

[xianglu, 2017-01-10 22:43:29]

PTAL.

[Ken Rockot(use gerrit already), 2017-01-10 22:45:25]

rs lgtm for mechanical move

[xianglu, 2017-01-10 22:53:40]

Description was changed from

==========
Shape Detection: Move mojom interface to //services

This CL moves Shape Detection interfaces to //services. This exposes them to
public instead of just Blink.

Blocking: https://codereview.chromium.org/2460723003/


BUG=646083, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Move mojom interface to //services

This CL moves Shape Detection mojo interfaces to //services, which exposes them
to public instead of just Blink.

Blocking: https://codereview.chromium.org/2460723003/


BUG=646083, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xianglu, 2017-01-10 22:58:38]

Description was changed from

==========
Shape Detection: Move mojom interface to //services

This CL moves Shape Detection mojo interfaces to //services, which exposes them
to public instead of just Blink.

Blocking: https://codereview.chromium.org/2460723003/


BUG=646083, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Move mojom interface to //services

This CL moves Shape Detection mojo interfaces to //services, which exposes them
to public instead of just Blink. No new code added.

Blocking: https://codereview.chromium.org/2460723003/


BUG=646083, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Tom Sepez, 2017-01-10 23:58:41]

lgtm

[commit-bot: I haz the power, 2017-01-11 00:48:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 00:48:22]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2017-01-11 18:06:28]

lgtm

stampity stamp

[David Trainor- moved to gerrit, 2017-01-11 18:20:38]

*.java lgtm!

[xianglu, 2017-01-11 20:18:47]

Description was changed from

==========
Shape Detection: Move mojom interface to //services

This CL moves Shape Detection mojo interfaces to //services, which exposes them
to public instead of just Blink. No new code added.

Blocking: https://codereview.chromium.org/2460723003/


BUG=646083, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Move mojom interface to //services

This CL moves Shape Detection mojo interfaces to //services, which exposes them
to public instead of just Blink. No new code added.

Blocking: https://codereview.chromium.org/2460723003/


TBR=haraken@chromium.org (mechanical move)
BUG=646083, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xianglu, 2017-01-11 20:19:06]

The CQ bit was checked by xianglu@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:19:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 20:49:56]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484165946934630,
"parent_rev": "4ef48a4037ea44d220fbe9f468d3ac659a38f9cb", "commit_rev":
"b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3"}

[commit-bot: I haz the power, 2017-01-11 20:50:26]

Description was changed from

==========
Shape Detection: Move mojom interface to //services

This CL moves Shape Detection mojo interfaces to //services, which exposes them
to public instead of just Blink. No new code added.

Blocking: https://codereview.chromium.org/2460723003/


TBR=haraken@chromium.org (mechanical move)
BUG=646083, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Shape Detection: Move mojom interface to //services

This CL moves Shape Detection mojo interfaces to //services, which exposes them
to public instead of just Blink. No new code added.

Blocking: https://codereview.chromium.org/2460723003/


TBR=haraken@chromium.org (mechanical move)
BUG=646083, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2620083002
Cr-Commit-Position: refs/heads/master@{#442991}
Committed:
https://chromium.googlesource.com/chromium/src/+/b38f05eb1dcc47b3d4fbe79f4a5d...
==========

[commit-bot: I haz the power, 2017-01-11 20:50:27]

Committed patchset #1 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/b38f05eb1dcc47b3d4fbe79f4a5d...

[haraken, 2017-01-11 23:30:34]

WebKit LGTM

[Wez, 2017-02-07 05:55:40]

wez@chromium.org changed reviewers:
+ thakis@chromium.org, wez@chromium.org

[Wez, 2017-02-07 05:55:41]

Hallo thakis@chromium.org!
Due to a depot_tools patch which mistakenly removed the OWNERS check for
non-source files (see crbug.com/684270), the following files landed in this CL
and need a retrospective review from you:
	chrome/browser/DEPS
Thanks,
Wez

[Nico, 2017-02-07 16:06:50]

chrome/browser/DEPS lgtm