Adds the touch calibration setting behind a chrome switch

Adds the touch calibration setting behind a chrome switch

 - Adds the touch calibration setting to settings > display
 - Adds a command line switch to enable the settings.
 - Updates system_display.idl to add a new parameter.

BUG=634166
COMPONENT=System Display API, ChromeOS Switch, md settings
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2620073002
Cr-Commit-Position: refs/heads/master@{#443052}
Committed: https://chromium.googlesource.com/chromium/src/+/205a9955bdcfbe37d8eecaad964e564a39fc4ef3

[malaykeshav, 2017-01-10 19:08:32]

Description was changed from

==========
Adds the touch calibration setting behind a chrome switch

 - Adds the touch calibration setting to settings > display
 - Adds a command line switch to enable the settings.
 - Updates system_display.idl to add a new parameter.

BUG=634166
COMPONENT=System Display API, ChromeOS Switch, md settings
==========

to

==========
Adds the touch calibration setting behind a chrome switch

 - Adds the touch calibration setting to settings > display
 - Adds a command line switch to enable the settings.
 - Updates system_display.idl to add a new parameter.

BUG=634166
COMPONENT=System Display API, ChromeOS Switch, md settings
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[malaykeshav, 2017-01-10 19:11:12]

Patchset #1 (id:1) has been deleted

[malaykeshav, 2017-01-10 19:12:40]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 19:13:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2017-01-10 19:13:22]

malaykeshav@chromium.org changed reviewers:
+ stevenjb@chromium.org

[malaykeshav, 2017-01-10 19:13:23]

Adds the md settings for touch calibration behind a flag.
PTAL

[commit-bot: I haz the power, 2017-01-10 20:44:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 20:44:49]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2017-01-10 21:14:00]

https://codereview.chromium.org/2620073002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display.html (right):

https://codereview.chromium.org/2620073002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display.html:147: <div
id="subpage-trigger" class="settings-box embedded two-line"
Duplicate id. (Neither appears to be necessary).

[malaykeshav, 2017-01-10 23:09:32]

PTAL

https://codereview.chromium.org/2620073002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display.html (right):

https://codereview.chromium.org/2620073002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display.html:147: <div
id="subpage-trigger" class="settings-box embedded two-line"
On 2017/01/10 21:13:59, stevenjb wrote:
> Duplicate id. (Neither appears to be necessary).

Done.

[malaykeshav, 2017-01-10 23:09:38]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 23:10:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 00:43:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 00:43:56]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2017-01-11 18:22:52]

lgtm

https://codereview.chromium.org/2620073002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display.html (right):

https://codereview.chromium.org/2620073002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display.html:133: <div
id="subpage-trigger" class="settings-box embedded two-line"
nit: Could you remove this id also?

[malaykeshav, 2017-01-11 19:24:17]

https://codereview.chromium.org/2620073002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display.html (right):

https://codereview.chromium.org/2620073002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display.html:133: <div
id="subpage-trigger" class="settings-box embedded two-line"
On 2017/01/11 18:22:52, stevenjb wrote:
> nit: Could you remove this id also?

Done.

[malaykeshav, 2017-01-11 19:25:00]

The CQ bit was checked by malaykeshav@chromium.org

[malaykeshav, 2017-01-11 19:25:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2620073002/#ps60001
(title: "nits")

[commit-bot: I haz the power, 2017-01-11 19:26:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 19:50:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 19:50:49]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[malaykeshav, 2017-01-11 20:43:10]

The CQ bit was checked by malaykeshav@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:43:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2017-01-11 21:51:10]

The CQ bit was unchecked by malaykeshav@chromium.org

[malaykeshav, 2017-01-11 21:51:12]

The CQ bit was checked by malaykeshav@chromium.org

[commit-bot: I haz the power, 2017-01-11 21:52:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 23:20:38]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484171472970820,
"parent_rev": "82f137db47aaedf2f741cd2615c735a1980dc7ce", "commit_rev":
"205a9955bdcfbe37d8eecaad964e564a39fc4ef3"}

[commit-bot: I haz the power, 2017-01-11 23:21:10]

Description was changed from

==========
Adds the touch calibration setting behind a chrome switch

 - Adds the touch calibration setting to settings > display
 - Adds a command line switch to enable the settings.
 - Updates system_display.idl to add a new parameter.

BUG=634166
COMPONENT=System Display API, ChromeOS Switch, md settings
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Adds the touch calibration setting behind a chrome switch

 - Adds the touch calibration setting to settings > display
 - Adds a command line switch to enable the settings.
 - Updates system_display.idl to add a new parameter.

BUG=634166
COMPONENT=System Display API, ChromeOS Switch, md settings
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2620073002
Cr-Commit-Position: refs/heads/master@{#443052}
Committed:
https://chromium.googlesource.com/chromium/src/+/205a9955bdcfbe37d8eecaad964e...
==========

[commit-bot: I haz the power, 2017-01-11 23:21:14]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/205a9955bdcfbe37d8eecaad964e...

[Wez, 2017-02-07 19:22:25]

wez@chromium.org changed reviewers:
+ asargent@chromium.org

[Wez, 2017-02-07 19:22:25]

Hallo asargent@chromium.org!
Due to a depot_tools patch which mistakenly removed the OWNERS check for
non-source files (see crbug.com/684270), the following files landed in this CL
and need a retrospective rubber-stamp review from you:
	extensions/common/api/system_display.idl
Thanks,
Wez

[asargent_no_longer_on_chrome, 2017-02-07 19:23:55]

asargent@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[asargent_no_longer_on_chrome, 2017-02-07 19:23:56]

passing off to rdevlin.cronin

[asargent_no_longer_on_chrome, 2017-02-07 19:24:12]

Description was changed from

==========
Adds the touch calibration setting behind a chrome switch

 - Adds the touch calibration setting to settings > display
 - Adds a command line switch to enable the settings.
 - Updates system_display.idl to add a new parameter.

BUG=634166
COMPONENT=System Display API, ChromeOS Switch, md settings
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2620073002
Cr-Commit-Position: refs/heads/master@{#443052}
Committed:
https://chromium.googlesource.com/chromium/src/+/205a9955bdcfbe37d8eecaad964e...
==========

to

==========
Adds the touch calibration setting behind a chrome switch

 - Adds the touch calibration setting to settings > display
 - Adds a command line switch to enable the settings.
 - Updates system_display.idl to add a new parameter.

BUG=634166
COMPONENT=System Display API, ChromeOS Switch, md settings
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2620073002
Cr-Commit-Position: refs/heads/master@{#443052}
Committed:
https://chromium.googlesource.com/chromium/src/+/205a9955bdcfbe37d8eecaad964e...
==========

[asargent_no_longer_on_chrome, 2017-02-07 19:24:12]

asargent@chromium.org changed reviewers:
- asargent@chromium.org

[Devlin, 2017-03-21 19:05:25]

On 2017/02/07 19:23:56, asargent_no_longer_on_chrome wrote:
> passing off to rdevlin.cronin

retro lgtm, courtesy of crbug.com/684270.