Disable OES_standard_derivative with Vivante GPUs.

Disable OES_standard_derivative with Vivante GPUs.

BUG=368005
TEST=
R=kbr@chromium.org,qinmin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268015

[Zhenyao Mo, 2014-05-02 23:20:49]

Please take a look

[qinmin, 2014-05-02 23:23:56]

lgtm

found a similar issue on bugzilla.mozilla.org:
https://bugzilla.mozilla.org/show_bug.cgi?id=958256

[Ken Russell (switch to Gerrit), 2014-05-02 23:26:12]

Does this really work to address the issue? Or is this a bug in our shader
translator where we're emitting the wrong #extension directive? It looks like it
should be:

#extension GL_OES_standard_derivatives : enable

rather than 'require'.

Where's the 'require' coming from?

Will stopping exposing GL_OES_standard_derivatives to the client really stop
them from putting in an #extension directive that's potentially wrong? Or will
we just ignore it?

https://codereview.chromium.org/262003003/diff/1/gpu/config/gpu_driver_bug_li...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/262003003/diff/1/gpu/config/gpu_driver_bug_li...
gpu/config/gpu_driver_bug_list_json.cc:945: "value": "GL_VIV_shader_binary"
Is this really the best way to detect these GPUs?

[Ken Russell (switch to Gerrit), 2014-05-02 23:26:30]

BTW, LGTM if this has been tested and verified to fix the issue.

[Zhenyao Mo, 2014-05-02 23:46:00]

I'll look more into why we issue the #extension GL_OES_standard_derivative:
require

I vaguely remember I looked into this before, but couldn't find code where it
happens in ANGLE translator.  Will keep digging it up.

However, this is a driver bug no matter whether we issue the statement
incorrectly or not, as the GL and shader compiler is inconsistent, so we should
get this workaround in anyway.

https://codereview.chromium.org/262003003/diff/1/gpu/config/gpu_driver_bug_li...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/262003003/diff/1/gpu/config/gpu_driver_bug_li...
gpu/config/gpu_driver_bug_list_json.cc:945: "value": "GL_VIV_shader_binary"
On 2014/05/02 23:26:12, Ken Russell wrote:
> Is this really the best way to detect these GPUs?

Yes, sometimes the "Vivante" isn't in the GL_VENDOR string, so we have to use
this ugly workaround.

[Zhenyao Mo, 2014-05-03 00:28:43]

Confirmed by qinmin, this does fix the bug.

[Zhenyao Mo, 2014-05-03 00:33:52]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2014-05-03 00:34:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zmo@chromium.org/262003003/1

[commit-bot: I haz the power, 2014-05-03 02:36:17]

Change committed as 268015